Skip to content

Export ParseDSN and Config #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2016
Merged

Export ParseDSN and Config #403

merged 2 commits into from
Jan 18, 2016

Conversation

julienschmidt
Copy link
Member

  • moved Config struct from connection.go and ParseDSN related code from utils.go to dsn.go
  • moved ParseDSN related tests from utils_test.go to dsn_test.go and updated them.
  • handle all DSN params at the same place. Before, parseTime, strict and compress where handled differently
  • Fixed a bug with getSystemVar and parseTime=true

Fixes #224

@julienschmidt julienschmidt added this to the v1.3 milestone Jan 13, 2016
@julienschmidt julienschmidt mentioned this pull request Jan 16, 2016
Merged
@arnehormann
Copy link
Member

LGTM

julienschmidt added a commit that referenced this pull request Jan 18, 2016
@julienschmidt
Merge pull request #403 from go-sql-driver/dsn
809154b 
Export ParseDSN and Config
@julienschmidt julienschmidt merged commit 809154b into master Jan 18, 2016
@julienschmidt julienschmidt deleted the dsn branch January 18, 2016 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@julienschmidt @arnehormann