Skip to content

Convert UnexpectedEOF to ErrBadConn when safe APIs #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
methane opened this issue Oct 24, 2018 · 0 comments
Closed

Convert UnexpectedEOF to ErrBadConn when safe APIs #883

methane opened this issue Oct 24, 2018 · 0 comments

Comments

@methane
Copy link
Member

methane commented Oct 24, 2018

In Query and Exec, ErrBadConn can be returned only before sending query.

On the other hand, in case of Ping, Prepare and Begin, it's safe to retry.
We can convert io.UnexpectedEOF to ErrBadConn.

Ref: #657

If #882 is implemented for all important platform, I think this is not necessary.
@methane methane closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@methane