Skip to content

Package is not compatible with go1.1 anymore #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeertJohan opened this issue Feb 17, 2015 · 2 comments
Closed

Package is not compatible with go1.1 anymore #316

GeertJohan opened this issue Feb 17, 2015 · 2 comments

Comments

@GeertJohan
Copy link

The travis build for gorp failed with an error in the go1.1 build:
../../go-sql-driver/mysql/connection.go:202: undefined: strings.IndexByte
This is because strings.IndexByte was added in go1.2. See: https://golang.org/doc/go1.2

This package states to be compatible with go1.1 in the readme.

Go 1.1 or higher

I dont think this package has to stay compatible with go1.1. It's a very old release and most projects have no trouble upgrading to newer versions of Go because of the great compatibility. Only projects abusing bugs or erroneous behavior in old versions of Go will have trouble upgrading, but they should fix their code anyway.

At the gorp project, I've proposed to only support the last 2 minor versions of Go: go-gorp/gorp#225

@julienschmidt
Copy link
Member

Yes, we intentionally removed Go 1.1 support (bfbe6c5).
Unfortunately, we forgot to update the README: #317
Sorry for the inconvenience we caused.

@GeertJohan
Copy link
Author

No problem. Made us think about our version support too.
Thanks for the fast reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants