Skip to content

Improve ErrBadConn #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
methane opened this issue May 16, 2024 · 1 comment
Closed

Improve ErrBadConn #1582

methane opened this issue May 16, 2024 · 1 comment

Comments

@methane
Copy link
Member

methane commented May 16, 2024

We have dropped old go versions. So we can improve how ErrBadConn handled.

Since database/sql uses IsValid() and ResetSession() to check connection, we can return i/o errors without translating them into ErrBadConn.

We should remove errBadConnNoWrite too.
@methane methane mentioned this issue May 16, 2024
Closed
5 tasks
@coderabbitai coderabbitai bot mentioned this issue Jun 14, 2024
Merged
5 tasks
@methane
Copy link
Member Author

methane commented Dec 1, 2024

fixed by #1641 and #1642.

@methane methane closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove errBadConnNoWrite and markBadConn methane/mysql
1 participant
@methane