NULL insertion fix

Author: julienschmidt

Diff for: driver_test.go

@@ -481,6 +481,24 @@ func TestNULL(t *testing.T) {
 	} else if ns.String != `1` {
 		t.Error("Unexpected NullString value:" + ns.String + " (should be `1`)")
 	}
+
+	// Insert NULL
+	mustExec(t, db, "CREATE TABLE test (dummmy1 int, value int, dummy2 int)")
+
+	mustExec(t, db, ("INSERT INTO test VALUES (?, ?, ?)"), 1, nil, 2)
+
+	var out interface{}
+	rows := mustQuery(t, db, ("SELECT * FROM test"))
+	if rows.Next() {
+		rows.Scan(&out)
+		if out != nil {
+			t.Errorf("%v != nil", out)
+		}
+	} else {
+		t.Error("no data")
+	}
+
+	mustExec(t, db, "DROP TABLE IF EXISTS test")
 }
 
 // Special cases

Diff for: packets.go

@@ -671,17 +671,17 @@ func (stmt *mysqlStmt) writeExecutePacket(args []driver.Value) error {
 		pos := 14 + ((stmt.paramCount + 7) >> 3)
 		// Convert bitMask to bytes
 		for i = 14; i < pos; i++ {
-			data[i] = byte(bitMask >> uint(i<<3))
+			data[i] = byte(bitMask >> uint((i-14)<<3))
 		}
 
 		// newParameterBoundFlag 1 [1 byte]
 		data[pos] = 0x01
 		pos++
 
-		// type of parameters [param_count*2 byte]
+		// type of parameters [param_count*2 bytes]
 		pos += copy(data[pos:], paramTypes)
 
-		// values for the parameters [n byte]
+		// values for the parameters [n bytes]
 		for i = range paramValues {
 			pos += copy(data[pos:], paramValues[i])
 		}