Skip to content

Commit a34e090

Browse files
authored
use utf8mb4 instead of utf8 in TestCharset (#1228)
From MySQL 8.0.24, `SELECT @@character_set_connection` reports utf8mb3 or utf8mb4 instead of utf8. Because utf8 is currently an alias for utf8mb3, however at some point utf8 is expected to become a reference to utf8mb4. > ref. https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-24.html#mysqld-8-0-24-bug > Important Note: When a utf8mb3 collation was specified in a CREATE TABLE statement, SHOW CREATE TABLE, DEFAULT CHARSET, > the values of system variables containing character set names, > and the binary log all subsequently displayed the character set as utf8 which is becoming a synonym for utf8mb4. > Now in such cases, utf8mb3 is shown instead, and CREATE TABLE raises the warning 'collation_name' is a collation of the deprecated character set UTF8MB3. > Please consider using UTF8MB4 with an appropriate collation instead. (Bug #27225287, Bug #32085357, Bug #32122844) > > References: See also: Bug #30624990. The document says that we should use utf8mb4 instead of utf8, so we should follow it.
1 parent 21f789c commit a34e090

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

driver_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -1450,11 +1450,11 @@ func TestCharset(t *testing.T) {
14501450
mustSetCharset("charset=ascii", "ascii")
14511451

14521452
// when the first charset is invalid, use the second
1453-
mustSetCharset("charset=none,utf8", "utf8")
1453+
mustSetCharset("charset=none,utf8mb4", "utf8mb4")
14541454

14551455
// when the first charset is valid, use it
1456-
mustSetCharset("charset=ascii,utf8", "ascii")
1457-
mustSetCharset("charset=utf8,ascii", "utf8")
1456+
mustSetCharset("charset=ascii,utf8mb4", "ascii")
1457+
mustSetCharset("charset=utf8mb4,ascii", "utf8mb4")
14581458
}
14591459

14601460
func TestFailingCharset(t *testing.T) {

0 commit comments

Comments
 (0)