mark fail, mustExec and mustQuery as test helpers (#1488)

shogo82148 · web-flow · commit 278a0b9e6b34 · 2023-10-10T17:48:58.000+09:00
diff --git a/driver_test.go b/driver_test.go
@@ -165,13 +165,15 @@ func runTests(t *testing.T, dsn string, tests ...func(dbt *DBTest)) {
 }
 
 func (dbt *DBTest) fail(method, query string, err error) {
+	dbt.Helper()
 	if len(query) > 300 {
 		query = "[query too large to print]"
 	}
 	dbt.Fatalf("error on %s %s: %s", method, query, err.Error())
 }
 
 func (dbt *DBTest) mustExec(query string, args ...interface{}) (res sql.Result) {
+	dbt.Helper()
 	res, err := dbt.db.Exec(query, args...)
 	if err != nil {
 		dbt.fail("exec", query, err)
@@ -180,6 +182,7 @@ func (dbt *DBTest) mustExec(query string, args ...interface{}) (res sql.Result)
 }
 
 func (dbt *DBTest) mustQuery(query string, args ...interface{}) (rows *sql.Rows) {
+	dbt.Helper()
 	rows, err := dbt.db.Query(query, args...)
 	if err != nil {
 		dbt.fail("query", query, err)

Original file line number	Diff line number	Diff line change
`@@ -165,13 +165,15 @@ func runTests(t testing.T, dsn string, tests ...func(dbt DBTest)) {`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`func (dbt *DBTest) fail(method, query string, err error) {`
	`168`	`+ dbt.Helper()`
`168`	`169`	`if len(query) > 300 {`
`169`	`170`	`query = "[query too large to print]"`
`170`	`171`	`}`
`171`	`172`	`dbt.Fatalf("error on %s %s: %s", method, query, err.Error())`
`172`	`173`	`}`
`173`	`174`
`174`	`175`	`func (dbt *DBTest) mustExec(query string, args ...interface{}) (res sql.Result) {`
	`176`	`+ dbt.Helper()`
`175`	`177`	`res, err := dbt.db.Exec(query, args...)`
`176`	`178`	`if err != nil {`
`177`	`179`	`dbt.fail("exec", query, err)`
`@@ -180,6 +182,7 @@ func (dbt *DBTest) mustExec(query string, args ...interface{}) (res sql.Result)`
`180`	`182`	`}`
`181`	`183`
`182`	`184`	`func (dbt DBTest) mustQuery(query string, args ...interface{}) (rows sql.Rows) {`
	`185`	`+ dbt.Helper()`
`183`	`186`	`rows, err := dbt.db.Query(query, args...)`
`184`	`187`	`if err != nil {`
`185`	`188`	`dbt.fail("query", query, err)`