Skip to content

Commit a3037c5

Browse files
authored
Merge pull request #732 from mcuelenaere/switch-logger-to-interface
Make logger require an interface instead of a concrete implementation
2 parents 8eb93a4 + 990004c commit a3037c5

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

canal/config.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
"github.com/go-mysql-org/go-mysql/mysql"
1313
"github.com/pingcap/errors"
1414
"github.com/siddontang/go-log/log"
15+
"github.com/siddontang/go-log/loggers"
1516
)
1617

1718
type DumpConfig struct {
@@ -91,7 +92,7 @@ type Config struct {
9192
TLSConfig *tls.Config
9293

9394
//Set Logger
94-
Logger *log.Logger
95+
Logger loggers.Advanced
9596

9697
//Set Dialer
9798
Dialer client.Dialer

canal/master.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"sync"
55

66
"github.com/go-mysql-org/go-mysql/mysql"
7-
"github.com/siddontang/go-log/log"
7+
"github.com/siddontang/go-log/loggers"
88
)
99

1010
type masterInfo struct {
@@ -16,7 +16,7 @@ type masterInfo struct {
1616

1717
timestamp uint32
1818

19-
logger *log.Logger
19+
logger loggers.Advanced
2020
}
2121

2222
func (m *masterInfo) Update(pos mysql.Position) {

replication/binlogsyncer.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import (
1111
"sync"
1212
"time"
1313

14+
"github.com/siddontang/go-log/loggers"
15+
1416
"github.com/google/uuid"
1517
"github.com/pingcap/errors"
1618
"github.com/siddontang/go-log/log"
@@ -112,7 +114,7 @@ type BinlogSyncerConfig struct {
112114
Option func(*client.Conn) error
113115

114116
// Set Logger
115-
Logger *log.Logger
117+
Logger loggers.Advanced
116118

117119
// Set Dialer
118120
Dialer client.Dialer

0 commit comments

Comments
 (0)