Skip to content

Commit 6cdf450

Browse files
authored
Merge pull request #690 from martinhrvn/uuid
Replacing github.com/satori/go.uuid with github.com/google/uuid
2 parents dc7d081 + 4b20384 commit 6cdf450

File tree

7 files changed

+19
-11
lines changed

7 files changed

+19
-11
lines changed

canal/sync.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import (
88
"github.com/go-mysql-org/go-mysql/mysql"
99
"github.com/go-mysql-org/go-mysql/replication"
1010
"github.com/go-mysql-org/go-mysql/schema"
11+
"github.com/google/uuid"
1112
"github.com/pingcap/errors"
1213
"github.com/pingcap/parser/ast"
13-
uuid "github.com/satori/go.uuid"
1414
"github.com/siddontang/go-log/log"
1515
)
1616

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ go 1.16
55
require (
66
github.com/BurntSushi/toml v0.3.1
77
github.com/go-sql-driver/mysql v1.5.0
8+
github.com/google/uuid v1.3.0
89
github.com/jmoiron/sqlx v1.3.3
910
github.com/pingcap/check v0.0.0-20190102082844-67f458068fc8
1011
github.com/pingcap/errors v0.11.5-0.20201126102027-b0a155152ca3
1112
github.com/pingcap/log v0.0.0-20210317133921-96f4fcab92a4 // indirect
1213
github.com/pingcap/parser v0.0.0-20210415081931-48e7f467fd74
13-
github.com/satori/go.uuid v1.2.0
1414
github.com/shopspring/decimal v0.0.0-20180709203117-cd690d0c9e24
1515
github.com/siddontang/go v0.0.0-20180604090527-bdc77568d726
1616
github.com/siddontang/go-log v0.0.0-20180807004314-8d05993dda07

go.sum

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ github.com/go-sql-driver/mysql v1.3.0/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG
1313
github.com/go-sql-driver/mysql v1.5.0 h1:ozyZYNQW3x3HtqT1jira07DN2PArx2v7/mN66gGcHOs=
1414
github.com/go-sql-driver/mysql v1.5.0/go.mod h1:DCzpHaOWr8IXmIStZouvnhqoel9Qv2LBy8hT2VhHyBg=
1515
github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
16+
github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
17+
github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
1618
github.com/jmoiron/sqlx v1.3.3 h1:j82X0bf7oQ27XeqxicSZsTU5suPwKElg3oyxNn43iTk=
1719
github.com/jmoiron/sqlx v1.3.3/go.mod h1:2BljVx/86SuTyjE+aPYlHCTNvZrnJXghYGpNiXLBMCQ=
1820
github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=

mysql/mysql_gtid.go

+6-4
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import (
1010
"strconv"
1111
"strings"
1212

13+
"github.com/google/uuid"
1314
"github.com/pingcap/errors"
14-
uuid "github.com/satori/go.uuid"
1515
"github.com/siddontang/go/hack"
1616
)
1717

@@ -174,7 +174,7 @@ func ParseUUIDSet(str string) (*UUIDSet, error) {
174174

175175
var err error
176176
s := new(UUIDSet)
177-
if s.SID, err = uuid.FromString(sep[0]); err != nil {
177+
if s.SID, err = uuid.Parse(sep[0]); err != nil {
178178
return nil, errors.Trace(err)
179179
}
180180

@@ -203,7 +203,7 @@ func NewUUIDSet(sid uuid.UUID, in ...Interval) *UUIDSet {
203203
}
204204

205205
func (s *UUIDSet) Contain(sub *UUIDSet) bool {
206-
if !bytes.Equal(s.SID.Bytes(), sub.SID.Bytes()) {
206+
if s.SID != sub.SID {
207207
return false
208208
}
209209

@@ -280,7 +280,9 @@ func (s *UUIDSet) String() string {
280280
}
281281

282282
func (s *UUIDSet) encode(w io.Writer) {
283-
_, _ = w.Write(s.SID.Bytes())
283+
b, _ := s.SID.MarshalBinary()
284+
285+
_, _ = w.Write(b)
284286
n := int64(len(s.Intervals))
285287

286288
_ = binary.Write(w, binary.LittleEndian, n)

replication/binlogsyncer.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import (
1010
"sync"
1111
"time"
1212

13+
"github.com/google/uuid"
1314
"github.com/pingcap/errors"
14-
uuid "github.com/satori/go.uuid"
1515
"github.com/siddontang/go-log/log"
1616

1717
"github.com/go-mysql-org/go-mysql/client"
@@ -312,7 +312,11 @@ func (b *BinlogSyncer) registerSlave() error {
312312
return errors.Trace(err)
313313
}
314314

315-
serverUUID := uuid.NewV1()
315+
serverUUID, err := uuid.NewUUID()
316+
if err != nil {
317+
log.Errorf("failed to get new uud %v", err)
318+
return errors.Trace(err)
319+
}
316320
if _, err = b.c.Execute(fmt.Sprintf("SET @slave_uuid = '%s', @replica_uuid = '%s'", serverUUID, serverUUID)); err != nil {
317321
log.Errorf("failed to set @slave_uuid = '%s', err: %v", serverUUID, err)
318322
return errors.Trace(err)

replication/event.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import (
1010
"time"
1111
"unicode"
1212

13+
"github.com/google/uuid"
1314
"github.com/pingcap/errors"
14-
uuid "github.com/satori/go.uuid"
1515

1616
. "github.com/go-mysql-org/go-mysql/mysql"
1717
)

replication/replication_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import (
1010
"testing"
1111
"time"
1212

13+
"github.com/google/uuid"
1314
. "github.com/pingcap/check"
14-
uuid "github.com/satori/go.uuid"
1515

1616
"github.com/go-mysql-org/go-mysql/client"
1717
"github.com/go-mysql-org/go-mysql/mysql"
@@ -339,7 +339,7 @@ func (t *testSyncerSuite) TestMysqlGTIDSync(c *C) {
339339

340340
var masterUuid uuid.UUID
341341
if s, _ := r.GetString(0, 1); len(s) > 0 && s != "NONE" {
342-
masterUuid, err = uuid.FromString(s)
342+
masterUuid, err = uuid.Parse(s)
343343
c.Assert(err, IsNil)
344344
}
345345

0 commit comments

Comments
 (0)