set read deadline for new conection to fix handshake stuck (#861)

tangenta · lance6716 · web-flow · commit 0ad0d03aedd0 · 2024-05-07T15:19:11.000+08:00
* set read deadline for new conection to fix handshake stuck

* fix linter

---------

Co-authored-by: lance6716 &lt;lance6716@gmail.com&gt;
diff --git a/replication/binlogsyncer.go b/replication/binlogsyncer.go
@@ -900,6 +900,9 @@ func (b *BinlogSyncer) newConnection(ctx context.Context) (*client.Conn, error)
 		"", b.cfg.Dialer, func(c *client.Conn) {
 			c.SetTLSConfig(b.cfg.TLSConfig)
 			c.SetAttributes(map[string]string{"_client_role": "binary_log_listener"})
+			if b.cfg.ReadTimeout > 0 {
+				_ = c.SetReadDeadline(time.Now().Add(b.cfg.ReadTimeout))
+			}
 		})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -900,6 +900,9 @@ func (b BinlogSyncer) newConnection(ctx context.Context) (client.Conn, error)`
`900`	`900`	`"", b.cfg.Dialer, func(c *client.Conn) {`
`901`	`901`	`c.SetTLSConfig(b.cfg.TLSConfig)`
`902`	`902`	`c.SetAttributes(map[string]string{"_client_role": "binary_log_listener"})`
	`903`	`+ if b.cfg.ReadTimeout > 0 {`
	`904`	`+ _ = c.SetReadDeadline(time.Now().Add(b.cfg.ReadTimeout))`
	`905`	`+ }`
`903`	`906`	`})`
`904`	`907`	`}`
`905`	`908`