build error: should omit comparison to bool constant

davidsvantesson · davidsvantesson · commit f20cfd39fb23 · 2019-09-29T13:16:18.000+02:00
Signed-off-by: David Svantesson &lt;davidsvantesson@gmail.com&gt;
diff --git a/models/org.go b/models/org.go
@@ -341,7 +341,7 @@ func IsPublicMembership(orgID, uid int64) (bool, error) {
 }
 
 func CanCreateOrgRepo(orgID, uid int64) (bool, error) {
-	if owner, err := IsOrganizationOwner(orgID, uid); owner == true || err != nil {
+	if owner, err := IsOrganizationOwner(orgID, uid); owner || err != nil {
 		return owner, err
 	}
 	return x.

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ func IsPublicMembership(orgID, uid int64) (bool, error) {`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`func CanCreateOrgRepo(orgID, uid int64) (bool, error) {`
`344`		`- if owner, err := IsOrganizationOwner(orgID, uid); owner == true \|\| err != nil {`
	`344`	`+ if owner, err := IsOrganizationOwner(orgID, uid); owner \|\| err != nil {`
`345`	`345`	`return owner, err`
`346`	`346`	`}`
`347`	`347`	`return x.`