PR feedback

philip-peterson · philip-peterson · commit dfed9bfe8e62 · 2023-03-05T23:01:04.000-05:00
diff --git a/modules/git/git.go b/modules/git/git.go
@@ -205,11 +205,7 @@ func enableReflogs() error {
 	if err := configSet("core.logAllRefUpdates", "true"); err != nil {
 		return err
 	}
-	if setting.Git.Reflog.Expiration != 90 {
-		if err := configSet("gc.reflogExpire", fmt.Sprintf("%d", setting.Git.Reflog.Expiration)); err != nil {
-			return err
-		}
-	} else if err := configUnsetAll("gc.reflogExpire", ""); err != nil {
+	if err := configSet("gc.reflogExpire", fmt.Sprintf("%d", setting.Git.Reflog.Expiration)); err != nil {
 		return err
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -205,11 +205,7 @@ func enableReflogs() error {`
`205`	`205`	`if err := configSet("core.logAllRefUpdates", "true"); err != nil {`
`206`	`206`	`return err`
`207`	`207`	`}`
`208`		`- if setting.Git.Reflog.Expiration != 90 {`
`209`		`- if err := configSet("gc.reflogExpire", fmt.Sprintf("%d", setting.Git.Reflog.Expiration)); err != nil {`
`210`		`- return err`
`211`		`- }`
`212`		`- } else if err := configUnsetAll("gc.reflogExpire", ""); err != nil {`
	`208`	`+ if err := configSet("gc.reflogExpire", fmt.Sprintf("%d", setting.Git.Reflog.Expiration)); err != nil {`
`213`	`209`	`return err`
`214`	`210`	`}`
`215`	`211`	`return nil`