Fix redirect bug when creating issue from a project (#23971)

lunny · web-flow · commit b918a2c4fb62 · 2023-04-08T16:17:50.000+08:00
Fix #23966
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -1154,8 +1154,8 @@ func NewIssuePost(ctx *context.Context) {
 	}
 
 	log.Trace("Issue created: %d/%d", repo.ID, issue.ID)
-	if ctx.FormString("redirect_after_creation") == "project" {
-		ctx.Redirect(ctx.Repo.RepoLink + "/projects/" + strconv.FormatInt(form.ProjectID, 10))
+	if ctx.FormString("redirect_after_creation") == "project" && projectID > 0 {
+		ctx.Redirect(ctx.Repo.RepoLink + "/projects/" + strconv.FormatInt(projectID, 10))
 	} else {
 		ctx.Redirect(issue.Link())
 	}

Original file line number	Diff line number	Diff line change
`@@ -1154,8 +1154,8 @@ func NewIssuePost(ctx *context.Context) {`
`1154`	`1154`	`}`
`1155`	`1155`
`1156`	`1156`	`log.Trace("Issue created: %d/%d", repo.ID, issue.ID)`
`1157`		`- if ctx.FormString("redirect_after_creation") == "project" {`
`1158`		`- ctx.Redirect(ctx.Repo.RepoLink + "/projects/" + strconv.FormatInt(form.ProjectID, 10))`
	`1157`	`+ if ctx.FormString("redirect_after_creation") == "project" && projectID > 0 {`
	`1158`	`+ ctx.Redirect(ctx.Repo.RepoLink + "/projects/" + strconv.FormatInt(projectID, 10))`
`1159`	`1159`	`} else {`
`1160`	`1160`	`ctx.Redirect(issue.Link())`
`1161`	`1161`	`}`