Enable linter [rule.modifies-value-receiver] and refactor RoleDescriptor (#18093)

Gusted · web-flow · commit a2afd38f2503 · 2021-12-26T22:56:14.000+08:00
diff --git a/.revive.toml b/.revive.toml
@@ -24,3 +24,4 @@ warningCode = 1
 [rule.indent-error-flow]
 [rule.errorf]
 [rule.duplicated-imports]
+[rule.modifies-value-receiver]
diff --git a/models/issue_comment.go b/models/issue_comment.go
@@ -123,8 +123,7 @@ const (
 
 // WithRole enable a specific tag on the RoleDescriptor.
 func (rd RoleDescriptor) WithRole(role RoleDescriptor) RoleDescriptor {
-	rd |= (1 << role)
-	return rd
+	return rd | (1 << role)
 }
 
 func stringToRoleDescriptor(role string) RoleDescriptor {

Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,7 @@ const (`
`123`	`123`
`124`	`124`	`// WithRole enable a specific tag on the RoleDescriptor.`
`125`	`125`	`func (rd RoleDescriptor) WithRole(role RoleDescriptor) RoleDescriptor {`
`126`		`- rd \|= (1 << role)`
`127`		`- return rd`
	`126`	`+ return rd \| (1 << role)`
`128`	`127`	`}`
`129`	`128`
`130`	`129`	`func stringToRoleDescriptor(role string) RoleDescriptor {`