Skip to content

Commit 87c64f6

Browse files
authored
Fix permission check on issue/pull lock (#22110)
Fix #21826
1 parent 36a2d2f commit 87c64f6

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

routers/web/web.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,6 @@ func RegisterRoutes(m *web.Route) {
655655
reqRepoReleaseWriter := context.RequireRepoWriter(unit.TypeReleases)
656656
reqRepoReleaseReader := context.RequireRepoReader(unit.TypeReleases)
657657
reqRepoWikiWriter := context.RequireRepoWriter(unit.TypeWiki)
658-
reqRepoIssueWriter := context.RequireRepoWriter(unit.TypeIssues)
659658
reqRepoIssueReader := context.RequireRepoReader(unit.TypeIssues)
660659
reqRepoPullsReader := context.RequireRepoReader(unit.TypePullRequests)
661660
reqRepoIssuesOrPullsWriter := context.RequireRepoWriterOr(unit.TypeIssues, unit.TypePullRequests)
@@ -992,8 +991,8 @@ func RegisterRoutes(m *web.Route) {
992991
})
993992
})
994993
m.Post("/reactions/{action}", web.Bind(forms.ReactionForm{}), repo.ChangeIssueReaction)
995-
m.Post("/lock", reqRepoIssueWriter, web.Bind(forms.IssueLockForm{}), repo.LockIssue)
996-
m.Post("/unlock", reqRepoIssueWriter, repo.UnlockIssue)
994+
m.Post("/lock", reqRepoIssuesOrPullsWriter, web.Bind(forms.IssueLockForm{}), repo.LockIssue)
995+
m.Post("/unlock", reqRepoIssuesOrPullsWriter, repo.UnlockIssue)
997996
m.Post("/delete", reqRepoAdmin, repo.DeleteIssue)
998997
}, context.RepoMustNotBeArchived())
999998
m.Group("/{index}", func() {

0 commit comments

Comments
 (0)