more efficient multiple notifyWatchers

Author: zeripath

models/repo_watch.go

@@ -165,11 +165,22 @@ func (repo *Repository) GetWatchers(page int) ([]*User, error) {
 }
 
 func notifyWatchers(e Engine, actions ...*Action) error {
+	var watchers []*Watch
+	var repo *Repository
+	var err error
+	var permCode []bool
+	var permIssue []bool
+	var permPR []bool
+
 	for _, act := range actions {
-		// Add feeds for user self and all watchers.
-		watches, err := getWatchers(e, act.RepoID)
-		if err != nil {
-			return fmt.Errorf("get watchers: %v", err)
+		repoChanged := repo == nil || repo.ID != act.RepoID
+
+		if repoChanged {
+			// Add feeds for user self and all watchers.
+			watchers, err = getWatchers(e, act.RepoID)
+			if err != nil {
+				return fmt.Errorf("get watchers: %v", err)
+			}
 		}
 
 		// Add feed for actioner.
@@ -178,10 +189,16 @@ func notifyWatchers(e Engine, actions ...*Action) error {
 			return fmt.Errorf("insert new actioner: %v", err)
 		}
 
-		act.loadRepo()
-		// check repo owner exist.
-		if err := act.Repo.getOwner(e); err != nil {
-			return fmt.Errorf("can't get repo owner: %v", err)
+		if repoChanged {
+			act.loadRepo()
+			repo = act.Repo
+
+			// check repo owner exist.
+			if err := act.Repo.getOwner(e); err != nil {
+				return fmt.Errorf("can't get repo owner: %v", err)
+			}
+		} else if act.Repo == nil {
+			act.Repo = repo
 		}
 
 		// Add feed for organization
@@ -193,26 +210,84 @@ func notifyWatchers(e Engine, actions ...*Action) error {
 			}
 		}
 
-		for i := range watches {
-			if act.ActUserID == watches[i].UserID {
+		if len(actions) == 1 {
+			// More efficient to just check the code and not cache
+			for _, watcher := range watchers {
+				if act.ActUserID == watcher.UserID {
+					continue
+				}
+
+				act.ID = 0
+				act.UserID = watcher.UserID
+				act.Repo.Units = nil
+
+				switch act.OpType {
+				case ActionCommitRepo, ActionPushTag, ActionDeleteTag, ActionDeleteBranch:
+					if !act.Repo.checkUnitUser(e, act.UserID, false, UnitTypeCode) {
+						continue
+					}
+				case ActionCreateIssue, ActionCommentIssue, ActionCloseIssue, ActionReopenIssue:
+					if !act.Repo.checkUnitUser(e, act.UserID, false, UnitTypeIssues) {
+						continue
+					}
+				case ActionCreatePullRequest, ActionMergePullRequest, ActionClosePullRequest, ActionReopenPullRequest:
+					if !act.Repo.checkUnitUser(e, act.UserID, false, UnitTypePullRequests) {
+						continue
+					}
+				}
+
+				if _, err = e.InsertOne(act); err != nil {
+					return fmt.Errorf("insert new action: %v", err)
+				}
+			}
+			return nil
+		}
+
+		if repoChanged {
+			permCode = make([]bool, len(watchers))
+			permIssue = make([]bool, len(watchers))
+			permPR = make([]bool, len(watchers))
+			for i, watcher := range watchers {
+				user, err := getUserByID(e, watcher.UserID)
+				if err != nil {
+					permCode[i] = false
+					permIssue[i] = false
+					permPR[i] = false
+					continue
+				}
+				perm, err := getUserRepoPermission(e, repo, user)
+				if err != nil {
+					permCode[i] = false
+					permIssue[i] = false
+					permPR[i] = false
+					continue
+				}
+				permCode[i] = perm.CanRead(UnitTypeCode)
+				permIssue[i] = perm.CanRead(UnitTypeIssues)
+				permPR[i] = perm.CanRead(UnitTypePullRequests)
+			}
+		}
+
+		for i, watcher := range watchers {
+			if act.ActUserID == watcher.UserID {
 				continue
 			}
 
 			act.ID = 0
-			act.UserID = watches[i].UserID
+			act.UserID = watcher.UserID
 			act.Repo.Units = nil
 
 			switch act.OpType {
 			case ActionCommitRepo, ActionPushTag, ActionDeleteTag, ActionDeleteBranch:
-				if !act.Repo.checkUnitUser(e, act.UserID, false, UnitTypeCode) {
+				if !permCode[i] {
 					continue
 				}
 			case ActionCreateIssue, ActionCommentIssue, ActionCloseIssue, ActionReopenIssue:
-				if !act.Repo.checkUnitUser(e, act.UserID, false, UnitTypeIssues) {
+				if !permIssue[i] {
 					continue
 				}
 			case ActionCreatePullRequest, ActionMergePullRequest, ActionClosePullRequest, ActionReopenPullRequest:
-				if !act.Repo.checkUnitUser(e, act.UserID, false, UnitTypePullRequests) {
+				if !permPR[i] {
 					continue
 				}
 			}