Set SSH_AUTHORIZED_KEYS_BACKUP to false (#25412)

techknowlogick · web-flow · commit 469d89b95a1c · 2023-07-01T04:07:48.000Z
This prevents the disk from overflowing with auth keys file Fixes #17117 ## ⚠️ BREAKING This changes the default option for creating a backup of the authorized key file when an update is made to default to false.
diff --git a/modules/setting/ssh.go b/modules/setting/ssh.go
@@ -173,7 +173,7 @@ func loadSSHFrom(rootCfg ConfigProvider) {
 		}
 	}
 
-	SSH.AuthorizedKeysBackup = sec.Key("SSH_AUTHORIZED_KEYS_BACKUP").MustBool(true)
+	SSH.AuthorizedKeysBackup = sec.Key("SSH_AUTHORIZED_KEYS_BACKUP").MustBool(false)
 	SSH.CreateAuthorizedKeysFile = sec.Key("SSH_CREATE_AUTHORIZED_KEYS_FILE").MustBool(true)
 
 	SSH.AuthorizedPrincipalsBackup = false

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ func loadSSHFrom(rootCfg ConfigProvider) {`
`173`	`173`	`}`
`174`	`174`	`}`
`175`	`175`
`176`		`- SSH.AuthorizedKeysBackup = sec.Key("SSH_AUTHORIZED_KEYS_BACKUP").MustBool(true)`
	`176`	`+ SSH.AuthorizedKeysBackup = sec.Key("SSH_AUTHORIZED_KEYS_BACKUP").MustBool(false)`
`177`	`177`	`SSH.CreateAuthorizedKeysFile = sec.Key("SSH_CREATE_AUTHORIZED_KEYS_FILE").MustBool(true)`
`178`	`178`
`179`	`179`	`SSH.AuthorizedPrincipalsBackup = false`