Skip to content

Commit 1cc1831

Browse files
committed
@lunny suggestion remove some not allowed fields
1 parent 2244b58 commit 1cc1831

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

models/issue.go

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1577,24 +1577,14 @@ func updateIssueByCols(e Engine, issue *Issue, columns ...string) (err error) {
15771577
// UpdateIssueByAPI updates all allowed fields of given issue.
15781578
func UpdateIssueByAPI(issue *Issue) error {
15791579
// allowed fields to update
1580-
columns := []string{"name", "is_closed", "content", "milestone_id",
1581-
"priority", "num_comments", "ref", "deadline_unix", "created_unix",
1582-
"updated_unix", "closed_unix", "is_locked"}
1580+
columns := []string{"name", "is_closed", "content", "milestone_id", "priority",
1581+
"deadline_unix", "updated_unix", "closed_unix", "is_locked"}
15831582

15841583
sess := x.NewSession()
15851584
defer sess.Close()
15861585
if err := sess.Begin(); err != nil {
15871586
return err
15881587
}
1589-
if err := issue.loadPoster(sess); err != nil {
1590-
return err
1591-
}
1592-
if !issue.Poster.IsGhost() {
1593-
if issue.PosterID <= 0 {
1594-
return fmt.Errorf("Issue %d can't be updated with PosterID %d", issue.Index, issue.PosterID)
1595-
}
1596-
columns = append(columns, "poster_id")
1597-
}
15981588

15991589
if err := updateIssueByCols(sess, issue, columns...); err != nil {
16001590
return err

0 commit comments

Comments
 (0)