Skip to content

Commit 53b3fc5

Browse files
tmandryCommit Bot
authored and
Commit Bot
committed
[rust] Enable mutable-noalias
We haven't seen any regressions upstream since it was last enabled again in March 2021: rust-lang/rust#82834. This results in a negligible increase in binary size of 24-56 kiB, depending on build configuration. Runtime perf only changed on x64 builds. 46 test cases got faster and 18 test cases got slower, with a couple of significant regressions in FIDL microbenchmarks. Overall the results look positive. Fixed: 76297 Change-Id: Id4a2b643e30e748e8d200f9d88c54ecc0ea02b2c Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/674307 Commit-Queue: Tyler Mandry <[email protected]> Reviewed-by: Dan Johnson <[email protected]>
1 parent 6a6322f commit 53b3fc5

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

build/config/BUILDCONFIG.gn

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -369,11 +369,7 @@ if (in_default_toolchain) {
369369
}
370370

371371
# Prepend the prefix configs, if any, before the default ones.
372-
default_common_binary_configs =
373-
toolchain_variant.prefix_configs + [
374-
# TODO(fxbug.dev/76297) Remove this to re-enable mutable-noalias.
375-
"//build/config/rust:no_mutable_noalias",
376-
]
372+
default_common_binary_configs = toolchain_variant.prefix_configs
377373

378374
# Note that Zircon toolchains and non-Zircon ones have a very different set
379375
# of default configs for all target types.

build/config/rust/BUILD.gn

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,6 @@ config("v0_symbol_mangling") {
119119
}
120120
}
121121

122-
# TODO(fxbug.dev/76297) Remove this to re-enable mutable-noalias.
123-
config("no_mutable_noalias") {
124-
rustflags = [ "-Zmutable-noalias=off" ]
125-
}
126-
127122
config("allow_unknown_lints") {
128123
rustflags = [ "-Aunknown-lints" ]
129124
}

0 commit comments

Comments
 (0)