Skip to content
This repository was archived by the owner on Jul 17, 2023. It is now read-only.

Commit c36a994

Browse files
committed
Merge pull request #56 from glyptodon/blank-default
GUAC-987: Ensure all enum parameters have legal blank values.
2 parents a8e4f95 + 9176164 commit c36a994

File tree

3 files changed

+14
-8
lines changed
  • guacamole/src/main/webapp/translations
  • guacamole-ext/src/main/resources/org/glyptodon/guacamole/protocols

3 files changed

+14
-8
lines changed

guacamole-ext/src/main/resources/org/glyptodon/guacamole/protocols/rdp.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@
1212
<param name="height" type="numeric" title="Display height"/>
1313
<param name="dpi" type="numeric" title="Display resolution (DPI)"/>
1414
<param name="color-depth" type="enum" title="Color depth">
15+
<option value=""></option>
1516
<option value="8">256 color</option>
1617
<option value="16">Low color (16-bit)</option>
1718
<option value="24">True color (24-bit)</option>
1819
<option value="32">True color (32-bit)</option>
1920
</param>
2021

2122
<param name="server-layout" type="enum" title="Keyboard layout">
22-
<option value="">(default)</option>
23+
<option value=""></option>
2324
<option value="en-us-qwerty">US English (Qwerty)</option>
2425
<option value="fr-fr-azerty">French (Azerty)</option>
2526
<option value="de-de-qwertz">German (Qwertz)</option>
@@ -35,7 +36,7 @@
3536
<param name="drive-path" type="text" title="Drive path"/>
3637

3738
<param name="security" type="enum" title="Security mode">
38-
<option value="">(default)</option>
39+
<option value=""></option>
3940
<option value="rdp">RDP encryption</option>
4041
<option value="tls">TLS encryption</option>
4142
<option value="nla">NLA (Network Level Authentication)</option>

guacamole-ext/src/main/resources/org/glyptodon/guacamole/protocols/vnc.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,13 @@
88
<param name="swap-red-blue" type="boolean" title="Swap red/blue components" value="true"/>
99

1010
<param name="cursor" type="enum" title="Cursor">
11+
<option value=""></option>
1112
<option value="local">Local</option>
1213
<option value="remote">Remote</option>
1314
</param>
1415

1516
<param name="color-depth" type="enum" title="Color depth">
17+
<option value=""></option>
1618
<option value="8">256 color</option>
1719
<option value="16">Low color (16-bit)</option>
1820
<option value="24">True color (24-bit)</option>

guacamole/src/main/webapp/translations/en_US.json

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,15 +263,16 @@
263263
"FIELD_OPTION_COLOR_DEPTH_24" : "True color (24-bit)",
264264
"FIELD_OPTION_COLOR_DEPTH_32" : "True color (32-bit)",
265265
"FIELD_OPTION_COLOR_DEPTH_8" : "256 color",
266+
"FIELD_OPTION_COLOR_DEPTH_EMPTY" : "",
266267

267268
"FIELD_OPTION_SECURITY_ANY" : "Any",
268-
"FIELD_OPTION_SECURITY_EMPTY" : "(default)",
269+
"FIELD_OPTION_SECURITY_EMPTY" : "",
269270
"FIELD_OPTION_SECURITY_NLA" : "NLA (Network Level Authentication)",
270271
"FIELD_OPTION_SECURITY_RDP" : "RDP encryption",
271272
"FIELD_OPTION_SECURITY_TLS" : "TLS encryption",
272273

273274
"FIELD_OPTION_SERVER_LAYOUT_DE_DE_QWERTZ" : "German (Qwertz)",
274-
"FIELD_OPTION_SERVER_LAYOUT_EMPTY" : "(default)",
275+
"FIELD_OPTION_SERVER_LAYOUT_EMPTY" : "",
275276
"FIELD_OPTION_SERVER_LAYOUT_EN_US_QWERTY" : "US English (Qwerty)",
276277
"FIELD_OPTION_SERVER_LAYOUT_FAILSAFE" : "Unicode",
277278
"FIELD_OPTION_SERVER_LAYOUT_FR_FR_AZERTY" : "French (Azerty)",
@@ -357,11 +358,13 @@
357358
"FIELD_HEADER_READ_ONLY" : "Read-only:",
358359
"FIELD_HEADER_SWAP_RED_BLUE" : "Swap red/blue components:",
359360

360-
"FIELD_OPTION_COLOR_DEPTH_8" : "256 color",
361-
"FIELD_OPTION_COLOR_DEPTH_16" : "Low color (16-bit)",
362-
"FIELD_OPTION_COLOR_DEPTH_24" : "True color (24-bit)",
363-
"FIELD_OPTION_COLOR_DEPTH_32" : "True color (32-bit)",
361+
"FIELD_OPTION_COLOR_DEPTH_8" : "256 color",
362+
"FIELD_OPTION_COLOR_DEPTH_16" : "Low color (16-bit)",
363+
"FIELD_OPTION_COLOR_DEPTH_24" : "True color (24-bit)",
364+
"FIELD_OPTION_COLOR_DEPTH_32" : "True color (32-bit)",
365+
"FIELD_OPTION_COLOR_DEPTH_EMPTY" : "",
364366

367+
"FIELD_OPTION_CURSOR_EMPTY" : "",
365368
"FIELD_OPTION_CURSOR_LOCAL" : "Local",
366369
"FIELD_OPTION_CURSOR_REMOTE" : "Remote",
367370

0 commit comments

Comments
 (0)