Upgrade sqlparser-rs version to v0.40.0 (#1478)

ref. apache/datafusion-sqlparser-rs#1036

Author: panarch

Cargo.lock

@@ -24,7 +24,7 @@ iter-enum = "1"
 itertools = "0.12"
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
-sqlparser = { version = "0.39", features = ["serde", "bigdecimal"] }
+sqlparser = { version = "0.40", features = ["serde", "bigdecimal"] }
 thiserror = "1.0"
 strum_macros = "0.25"
 bigdecimal = { version = "0.4.1", features = ["serde", "string-only"] }

core/Cargo.toml

@@ -51,6 +51,9 @@ pub enum TranslateError {
     #[error("unnamed function arg is not supported")]
     UnNamedFunctionArgNotSupported,
 
+    #[error("INSERT INTO {0} DEFAULT VALUES is not supported")]
+    DefaultValuesOnInsertNotSupported(String),
+
     #[error("empty function body is not supported")]
     UnsupportedEmptyFunctionBody,
 

core/src/translate/error.rs

@@ -35,11 +35,22 @@ pub fn translate(sql_statement: &SqlStatement) -> Result<Statement> {
             columns,
             source,
             ..
-        } => Ok(Statement::Insert {
-            table_name: translate_object_name(table_name)?,
-            columns: translate_idents(columns),
-            source: translate_query(source)?,
-        }),
+        } => {
+            let table_name = translate_object_name(table_name)?;
+            let columns = translate_idents(columns);
+            let source = source
+                .as_deref()
+                .ok_or_else(|| {
+                    TranslateError::DefaultValuesOnInsertNotSupported(table_name.clone()).into()
+                })
+                .and_then(translate_query)?;
+
+            Ok(Statement::Insert {
+                table_name,
+                columns,
+                source,
+            })
+        }
         SqlStatement::Update {
             table,
             assignments,
@@ -294,3 +305,18 @@ fn translate_object_name(sql_object_name: &SqlObjectName) -> Result<String> {
 pub fn translate_idents(idents: &[SqlIdent]) -> Vec<String> {
     idents.iter().map(|v| v.value.to_owned()).collect()
 }
+
+#[cfg(test)]
+mod tests {
+    use {super::*, crate::parse_sql::parse};
+
+    #[test]
+    fn statement() {
+        let sql = "INSERT INTO Foo DEFAULT VALUES";
+        let actual = parse(sql).and_then(|parsed| translate(&parsed[0]));
+        let expected =
+            Err(TranslateError::DefaultValuesOnInsertNotSupported("Foo".to_owned()).into());
+
+        assert_eq!(actual, expected);
+    }
+}