Skip to content

Commit f90b48d

Browse files
committed
chore(docs-app): fix vertical scrolling offset after recent re-design
Previously, the `yOffset` pointed to the `<header>` element, which had a height of 0 (since all its children have fixed positions). This caused scrolled items to have 0 vertical offset, essentially hiding the top part behind the static `<nav>` items. This commit fixes the vertical scrolling offset, by setting `yOffset` to the last (lowest) `<nav>` item. Closes angular#15945
1 parent dcc57f1 commit f90b48d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/config/templates/app/indexPage.template.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
</head>
7171
<body class="homepage">
7272
<div id="wrapper">
73-
<header class="header" scroll-y-offset-element>
73+
<header class="header">
7474
<nav id="navbar-main" class="navbar navbar-fixed-top">
7575
<div class="navbar-inner" ng-controller="DocsSearchCtrl">
7676
<div class="container">
@@ -156,7 +156,7 @@ <h4 class="search-results-group-heading">{{ key }}</h4>
156156
</div>
157157
</div>
158158
</nav>
159-
<nav id="navbar-sub" class="sup-header navbar navbar-fixed-top">
159+
<nav id="navbar-sub" class="sup-header navbar navbar-fixed-top" scroll-y-offset-element>
160160
<div class="container main-grid main-header-grid">
161161
<div class="grid-left">
162162
<version-picker></version-picker>

0 commit comments

Comments
 (0)