Skip to content

Commit b3dfb38

Browse files
refactor($http): avoid using closure vars in serverRequest fn
Closes angular#10361
1 parent 3b5ba87 commit b3dfb38

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/ng/http.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -738,23 +738,22 @@ function $HttpProvider() {
738738
</example>
739739
*/
740740
function $http(requestConfig) {
741-
var config = {
742-
method: 'get',
743-
transformRequest: defaults.transformRequest,
744-
transformResponse: defaults.transformResponse
745-
};
746-
var headers = mergeHeaders(requestConfig);
747741

748742
if (!angular.isObject(requestConfig)) {
749743
throw minErr('$http')('badreq', 'Http request configuration must be an object. Received: {0}', requestConfig);
750744
}
751745

752-
extend(config, requestConfig);
753-
config.headers = headers;
746+
var config = extend({
747+
method: 'get',
748+
transformRequest: defaults.transformRequest,
749+
transformResponse: defaults.transformResponse
750+
}, requestConfig);
751+
752+
config.headers = mergeHeaders(requestConfig);
754753
config.method = uppercase(config.method);
755754

756755
var serverRequest = function(config) {
757-
headers = config.headers;
756+
var headers = config.headers;
758757
var reqData = transformData(config.data, headersGetter(headers), config.transformRequest);
759758

760759
// strip content-type if data is undefined

0 commit comments

Comments
 (0)