fix(select): do not break when removing the element (e.g. via ngIf)

Fixes angular#15466

Author: gkalpak

src/ng/directive/select.js

@@ -75,9 +75,11 @@ var SelectController =
     }
   };
 
+  var scopeDestroyed = false;
   $scope.$on('$destroy', function() {
     // disable unknown option so that we don't do work when the whole select is being destroyed
     self.renderUnknownOption = noop;
+    scopeDestroyed = true;
   });
 
   // Read the value of the select control, the implementation of this changes depending
@@ -179,6 +181,8 @@ var SelectController =
     updateScheduled = true;
 
     $scope.$$postDigest(function() {
+      if (scopeDestroyed) return;
+
       updateScheduled = false;
       self.ngModelCtrl.$setViewValue(self.readValue());
       if (renderAfter) self.ngModelCtrl.$render();

test/ng/directive/selectSpec.js

@@ -7,7 +7,7 @@ describe('select', function() {
     formElement = jqLite('<form name="form">' + html + '</form>');
     element = formElement.find('select');
     $compile(formElement)(scope);
-    scope.$apply();
+    scope.$digest();
   }
 
   function compileRepeatedOptions() {
@@ -767,6 +767,20 @@ describe('select', function() {
         expect(element).toEqualSelect([unknownValue()], '1', '2', '3');
       }
     );
+
+
+    it('should not break when removing the element and all its children', function() {
+      var template =
+        '<select ng-model="mySelect" ng-if="visible">' +
+          '<option value="">--- Select ---</option>' +
+        '</select>';
+      scope.visible = true;
+
+      compile(template);
+
+      // It should not throw when removing the element
+      scope.$apply('visible = false');
+    });
   });