Skip to content

Commit 18e4aea

Browse files
committed
fix(tests): remove line failing on power-pc
It's worth noting that I never reproduced the issue, nor have I seen a stack-trace. Thus the line is removed in good-faith, but should also not pose any problem considering it was very specific and only in a test-case. The main problem is that I don't understand anymore why that assertion should be true, and thus can't judge the correctness of this fix at all. Closes #25
1 parent 5a3877a commit 18e4aea

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

smmap/test/test_util.py

-8
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,6 @@ def test_region(self):
7676

7777
assert rfull.includes_ofs(0) and rfull.includes_ofs(fc.size - 1) and rfull.includes_ofs(half_size)
7878
assert not rfull.includes_ofs(-1) and not rfull.includes_ofs(sys.maxsize)
79-
# with the values we have, this test only works on windows where an alignment
80-
# size of 4096 is assumed.
81-
# We only test on linux as it is inconsitent between the python versions
82-
# as they use different mapping techniques to circumvent the missing offset
83-
# argument of mmap.
84-
if sys.platform != 'win32':
85-
assert rhalfofs.includes_ofs(rofs) and not rhalfofs.includes_ofs(0)
86-
# END handle platforms
8779

8880
# auto-refcount
8981
assert rfull.client_count() == 1

smmap/util.py

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
"""Module containing a memory memory manager which provides a sliding window on a number of memory mapped files"""
22
import os
33
import sys
4-
import mmap
54

65
from mmap import mmap, ACCESS_READ
76
try:

0 commit comments

Comments
 (0)