Improved way of listing URLs in remote #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: git/util.py
Use flock() for file locking
Now that performance tests are run, it appears we run into one particular failure on travis, possibly indicating a bug in python 3.3. Just bluntly increason the amount of handles might silence it... . Related to gitpython-developers#524
instead of using git remote show that can trigger a connection to the remote repository, use git remote get-url --all that works by only reading the .git/config. change should have no functional impact, so no test needed. Signed-off-by: Guyzmo <[email protected]>
|
(I noticed the issue when doing a |
|
@guyzmo |
ankostis
pushed a commit
to ankostis/GitPython
that referenced
this pull request
Oct 11, 2016
+ Instead of using `git remote show` that may triggers connection to remote repo, use `git remote get-url --all` that works by only reading the `.git/config`. + Change should have no functional impact, so no test needed. + Works only with git -2.7+. Signed-off-by: Guyzmo <[email protected]>
ankostis
added a commit
to ankostis/GitPython
that referenced
this pull request
Oct 11, 2016
ankostis
pushed a commit
to ankostis/GitPython
that referenced
this pull request
Oct 12, 2016
|
looks like it's merged, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using git remote show that can trigger a connection to the
remote repository, use git remote get-url --all that works by only
reading the .git/config.
change should have no functional impact, so no test needed.
Signed-off-by: Guyzmo [email protected]