From cee0cec2d4a27bbc7af10b91a1ad39d735558798 Mon Sep 17 00:00:00 2001 From: Bert Wesarg Date: Tue, 19 Jul 2016 08:38:02 +0200 Subject: [PATCH 1/2] Add missing newline when writing a symbolic ref. --- git/refs/symbolic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git/refs/symbolic.py b/git/refs/symbolic.py index ae67a7ee8..d00ef6176 100644 --- a/git/refs/symbolic.py +++ b/git/refs/symbolic.py @@ -313,7 +313,7 @@ def set_reference(self, ref, logmsg=None): lfd = LockedFD(fpath) fd = lfd.open(write=True, stream=True) - fd.write(write_value.encode('ascii')) + fd.write(write_value.encode('ascii') + '\n') lfd.commit() # Adjust the reflog From b827f8162f61285754202bec8494192bc229f75a Mon Sep 17 00:00:00 2001 From: Bert Wesarg Date: Tue, 19 Jul 2016 09:17:51 +0200 Subject: [PATCH 2/2] Use binary string constant for concatenation. --- git/refs/symbolic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git/refs/symbolic.py b/git/refs/symbolic.py index d00ef6176..ec2944c6e 100644 --- a/git/refs/symbolic.py +++ b/git/refs/symbolic.py @@ -313,7 +313,7 @@ def set_reference(self, ref, logmsg=None): lfd = LockedFD(fpath) fd = lfd.open(write=True, stream=True) - fd.write(write_value.encode('ascii') + '\n') + fd.write(write_value.encode('ascii') + b'\n') lfd.commit() # Adjust the reflog