Split lines by new line characters #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opt to split lines by the new line character instead of letting `splitlines()` do this. This helps catch the issue when there are special characters in the line, particular the commit summary section.
|
|
||
| if line.strip() == '' or line.strip() == b'': | ||
| # Skip over empty lines | ||
| continue |
There was a problem hiding this comment.
Ohh, this actually has nothing to do with the ^M chars in the fixture. It's because of this:
>>> s = 'foo\nbar\n'
>>> s.splitlines()
['foo', 'bar']
>>> s.split('\n')
['foo', 'bar', '']
^^
|
Thanks, this is now pulled! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes a bug where there could be special characters in the commit message, causing the line splits to be improperly detected when parsing the blame metadata.
This commit opts to split lines by the new line character instead of letting
splitlines()do this. This helps catch the issue when there are special characters in the line, particular the commit summary section.How should this be manually tested?
git/test/test_repo.pyhas been modified to catch this edge case. Please do run all tests or this one test in particular.