Skip to content

remote.Remote.urls fails #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sstancu opened this issue Apr 5, 2019 · 0 comments · Fixed by #859
Closed

remote.Remote.urls fails #858

sstancu opened this issue Apr 5, 2019 · 0 comments · Fixed by #859

Comments

@sstancu
Copy link

sstancu commented Apr 5, 2019

It seems the fix for #694 only works if the current workin directory of the running program is within the git repository.

If the current working dir is outside the git repo, then the following (starting at git/remote.py:557)

                        result = Git().execute(
                            ['git', 'config', '--get', 'remote.%s.url' % self.name]
                        )

fails with:

git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git config --get remote.origin.url
@sstancu sstancu mentioned this issue Apr 5, 2019
@ghost ghost closed this as completed in #859 Jul 20, 2019
@Byron Byron added this to the v2.1.12 - Bugfixes milestone Jul 20, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants