Skip to content

On Windows, SymbolicReference._iter_items misses non-packed refs #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dubois opened this issue Feb 22, 2017 · 2 comments
Closed

On Windows, SymbolicReference._iter_items misses non-packed refs #586

dubois opened this issue Feb 22, 2017 · 2 comments

Comments

@dubois
Copy link

dubois commented Feb 22, 2017

repo.branches was not seeing some of my newly-created branches. I tracked it down to https://github.com/gitpython-developers/GitPython/blob/master/git/refs/symbolic.py#L577

        if 'refs/' not in root:  # skip non-refs subfolders

This needs to honor os.sep, eg:

        if 'refs' not in root.split(os.sep):  # skip non-refs subfolders
@Byron
Copy link
Member

Byron commented Feb 25, 2017

Thanks a lot for letting us know, and for suggesting a viable fix!

@ankostis
Copy link
Contributor

ankostis commented Mar 1, 2017

In order to support also CYGWIN Git, maybe it needs to check posix os.sep :-(

Is tm possible to have a simple TestCase to reproduce it in Appveyor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants