Skip to content

3.1.20: sphinx 4.x warnings #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kloczek opened this issue Aug 18, 2021 · 8 comments
Closed

3.1.20: sphinx 4.x warnings #1323

kloczek opened this issue Aug 18, 2021 · 8 comments
Assignees

Comments

@kloczek
Copy link

kloczek commented Aug 18, 2021

Looks like sphinx 4.x shows some warnings.

+ /usr/bin/python3 setup.py build_sphinx -b man --build-dir build/sphinx
running build_sphinx
Running Sphinx v4.1.2
making output directory... done
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: [new config] 6 added, 0 changed, 0 removed
reading sources... [100%] tutorial
/home/tkloczko/rpmbuild/BUILD/GitPython-3.1.20/doc/source/changes.rst:16: WARNING: Title underline too short.

3.1.19 (YANKED)
======
/home/tkloczko/rpmbuild/BUILD/GitPython-3.1.20/doc/source/changes.rst:16: WARNING: Title underline too short.

3.1.19 (YANKED)
======
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... python-gitpython.3 { intro tutorial reference roadmap changes } done
build succeeded, 2 warnings.
@Byron Byron self-assigned this Aug 19, 2021
@Byron
Copy link
Member

Byron commented Aug 19, 2021

Thanks for reporting.

It's unclear which version you are using for release, but in main the issue is fixed.

Hence I am closing the issue as no action can be performed here.

@Byron Byron closed this as completed Aug 19, 2021
@kloczek
Copy link
Author

kloczek commented Aug 19, 2021

It's unclear which version you are using for release, but in main the issue is fixed.

GitPython version is in the subject (3.1.20). Sphinx version is in the log (4.1.2)

@kloczek
Copy link
Author

kloczek commented Aug 19, 2021

Hence I am closing the issue as no action can be performed here.

Did you ever try to use command which is in firsr line of the quotesd log?
/usr/bin/python3 setup.py build_sphinx -b man --build-dir build/sphinx

@Byron
Copy link
Member

Byron commented Aug 19, 2021

No.

Are you suggesting there is a fix for this, and if so which one would that be? The headlines shown above don't exist in main.

@Byron Byron reopened this Aug 19, 2021
@kloczek
Copy link
Author

kloczek commented Aug 19, 2021

Just FTR .. please I'm not suggestion anything :)
I'm just a messenger which reported warning :P
It may be but in GitPython documentation or sphinx as well (or some sphinx extension).
Sorry to say that but still I have very long list of the python modules to package but on packaging anything all what I'm trying is at least report found issues (please peak on my profile and you will found that it is +90% of my last year github activity).
If I reported that not enough clear that is of course my fault ..

@Byron
Copy link
Member

Byron commented Aug 19, 2021

Sorry, I didn't mean to come across as condescending or aggressive or be disrespectful towards your work.

Let me express my confusion as to how to fix something that seems already fixed in main and that relates to a code snapshot that lies in the past.

Once clarified if this is fixable, the best course of action would be a PR that makes the changes. The cost of this issue seems already much higher than the cost of fixing it if it can be fixed.

@Yobmod
Copy link
Contributor

Yobmod commented Sep 9, 2021

AFAIK I fixed all sphinx warnings (for python <= 3.9), they just haven't been released yet #1318
So this should be closable on next release.
(Although sphinx is causing problems with 3.10 still)

@kloczek
Copy link
Author

kloczek commented Sep 9, 2021

OK than feel free to close this toicket and will retest that on next release and if still will be something will tell you :)

@Yobmod Yobmod closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants