Added Remote.exists() method, and test. Fixes #229

Author: Byron

git/remote.py

@@ -397,6 +397,19 @@ def __ne__(self, other):
     def __hash__(self):
         return hash(self.name)
 
+    def exists(self):
+        """:return: True if this is a valid, existing remote.
+        Valid remotes have an entry in the repository's configuration"""
+        try:
+            self.config_reader.get('url')
+            return True
+        except cp.NoOptionError:
+            # we have the section at least ... 
+            return True
+        except cp.NoSectionError:
+            return False
+        # end
+
     @classmethod
     def iter_items(cls, repo):
         """:return: Iterator yielding Remote objects of the given repository"""

git/repo/base.py

@@ -250,7 +250,10 @@ def remotes(self):
     def remote(self, name='origin'):
         """:return: Remote with the specified name
         :raise ValueError:  if no remote with such a name exists"""
-        return Remote(self, name)
+        r = Remote(self, name)
+        if not r.exists():
+            raise ValueError("Remote named '%s' didn't exist" % name)
+        return r
 
     #{ Submodules
 

git/test/test_repo.py

@@ -25,7 +25,8 @@
     Reference,
     GitDB,
     Submodule,
-    GitCmdObjectDB
+    GitCmdObjectDB,
+    Remote
 )
 from git.util import join_path_native
 from git.exc import BadObject
@@ -673,3 +674,7 @@ def last_commit(repo, rev, path):
                 last_commit(repo, 'master', 'git/test/test_base.py')
             # end for each repository type
         # end for each iteration
+
+    def test_remote_method(self):
+        self.failUnlessRaises(ValueError, self.rorepo.remote, 'foo-blue')
+        assert isinstance(self.rorepo.remote(name='origin'), Remote)