[#5330] Ensure wait() is called on git processes

Author: Cory Johns

git/cmd.py

@@ -80,6 +80,7 @@ def __del__(self):
 			# try to kill it
 			try:
 				os.kill(self.proc.pid, 2)	# interrupt signal
+				self.proc.wait()	# ensure process goes away
 			except AttributeError:
 				# try windows 
 				# for some reason, providing None for stdout/stderr still prints something. This is why 

git/objects/commit.py

@@ -8,6 +8,7 @@
 							Actor,
 							Iterable,
 							Stats,
+							finalize_process
 						)
 from git.diff import Diffable
 from tree import Tree
@@ -251,6 +252,8 @@ def _iter_from_process_or_stream(cls, repo, proc_or_stream):
 			assert len(hexsha) == 40, "Invalid line: %s" % hexsha
 			yield Commit(repo, hex_to_bin(hexsha))
 		# END for each line in stream
+		if has_attr(proc_or_stream, 'wait'):
+			finalize_process(proc_or_stream)
 
 
 	@classmethod

git/remote.py

@@ -24,7 +24,10 @@
 					TagReference
 				)
 
-from git.util import join_path
+from git.util import (
+		join_path,
+		finalize_process
+	)
 from gitdb.util import join
 
 import re
@@ -58,18 +61,6 @@ def digest_process_messages(fh, progress):
 	# END while file is not done reading
 	return dropped_lines
 
-def finalize_process(proc):
-	"""Wait for the process (clone, fetch, pull or push) and handle its errors accordingly"""
-	try:
-		proc.wait()
-	except GitCommandError,e:
-		# if a push has rejected items, the command has non-zero return status
-		# a return status of 128 indicates a connection error - reraise the previous one
-		if proc.poll() == 128:
-			raise
-		pass
-	# END exception handling
-
 def add_progress(kwargs, git, progress):
 	"""Add the --progress flag to the given kwargs dict if supported by the 
 	git command. If the actual progress in the given progress instance is not 

git/repo/base.py

@@ -6,15 +6,17 @@
 
 from git.exc import InvalidGitRepositoryError, NoSuchPathError
 from git.cmd import Git
-from git.util import Actor
+from git.util import (
+		Actor,
+		finalize_process
+	)
 from git.refs import *
 from git.index import IndexFile
 from git.objects import *
 from git.config import GitConfigParser
 from git.remote import (
 						Remote,
 						digest_process_messages,
-						finalize_process,
 						add_progress
 					)
 
@@ -541,6 +543,7 @@ def untracked_files(self):
 				untracked_files.append(untracked_info.replace("#\t", "").rstrip())
 			# END for each utracked info line
 		# END for each line
+		finalize_process(proc)
 		return untracked_files
 
 	@property

git/util.py

@@ -121,6 +121,18 @@ def get_user_id():
 	# END get username from login
 	return "%s@%s" % (username, platform.node())
 
+def finalize_process(proc):
+	"""Wait for the process (clone, fetch, pull or push) and handle its errors accordingly"""
+	try:
+		proc.wait()
+	except GitCommandError,e:
+		# if a push has rejected items, the command has non-zero return status
+		# a return status of 128 indicates a connection error - reraise the previous one
+		if proc.poll() == 128:
+			raise
+		pass
+	# END exception handling
+
 #} END utilities
 
 #{ Classes