Skip to content

Commit 7d98f94

Browse files
committed
Let all TestRmtree tests run on 3.7
They are no longer using TemporaryDirectory (because they use the pytest tmp_path fixture instead), so the limitations of TemporaryDirectory on Python 3.7 are no longer relevant.
1 parent c3d3d1e commit 7d98f94

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

Diff for: test/test_util.py

-8
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,6 @@ def test_deletes_dir_with_readonly_files(self, tmp_path):
106106
sys.platform == "cygwin",
107107
reason="Cygwin can't set the permissions that make the test meaningful.",
108108
)
109-
@pytest.mark.skipif(
110-
sys.version_info < (3, 8),
111-
reason="In 3.7, TemporaryDirectory doesn't clean up after weird permissions.",
112-
)
113109
def test_wraps_perm_error_if_enabled(self, mocker, permission_error_tmpdir):
114110
"""rmtree wraps PermissionError when HIDE_WINDOWS_KNOWN_ERRORS is true."""
115111
# Access the module through sys.modules so it is unambiguous which module's
@@ -129,10 +125,6 @@ def test_wraps_perm_error_if_enabled(self, mocker, permission_error_tmpdir):
129125
sys.platform == "cygwin",
130126
reason="Cygwin can't set the permissions that make the test meaningful.",
131127
)
132-
@pytest.mark.skipif(
133-
sys.version_info < (3, 8),
134-
reason="In 3.7, TemporaryDirectory doesn't clean up after weird permissions.",
135-
)
136128
def test_does_not_wrap_perm_error_unless_enabled(self, mocker, permission_error_tmpdir):
137129
"""rmtree does not wrap PermissionError when HIDE_WINDOWS_KNOWN_ERRORS is false."""
138130
# See comments in test_wraps_perm_error_if_enabled for details about patching.

0 commit comments

Comments
 (0)