Skip to content

Commit 76bcd70

Browse files
committed
Add types to commit.py undo
1 parent ce8cc4a commit 76bcd70

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

git/objects/commit.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ def __init__(self, repo, binsha, tree=None, author=None, authored_date=None, aut
129129
self.message = message
130130
if parents is not None:
131131
self.parents = parents
132-
self.parents_list = list(parents)
133132
if encoding is not None:
134133
self.encoding = encoding
135134
if gpgsig is not None:
@@ -480,17 +479,17 @@ def _deserialize(self, stream):
480479
readline = stream.readline
481480
self.tree = Tree(self.repo, hex_to_bin(readline().split()[1]), Tree.tree_id << 12, '')
482481

483-
self.parents_list = [] # List['Commit']
482+
self.parents = []
484483
next_line = None
485484
while True:
486485
parent_line = readline()
487486
if not parent_line.startswith(b'parent'):
488487
next_line = parent_line
489488
break
490489
# END abort reading parents
491-
self.parents_list.append(type(self)(self.repo, hex_to_bin(parent_line.split()[-1].decode('ascii'))))
490+
self.parents.append(type(self)(self.repo, hex_to_bin(parent_line.split()[-1].decode('ascii'))))
492491
# END for each parent line
493-
self.parents = tuple(self.parents_list) # type: Tuple['Commit', ...]
492+
self.parents = tuple(self.parents)
494493

495494
# we don't know actual author encoding before we have parsed it, so keep the lines around
496495
author_line = next_line

0 commit comments

Comments
 (0)