Greatly improved robustness of config parser - it can now take pretty much everything. Includes an updated config file which includes all the new additions

Author: Byron

Diff for: git/config.py

@@ -120,6 +120,7 @@ class GitConfigParser(cp.RawConfigParser, object):
 	# They must be compatible to the LockFile interface.
 	# A suitable alternative would be the BlockingLockFile
 	t_lock = LockFile
+	re_comment = re.compile('^\s*[#;]')
 
 	#} END configuration 
 
@@ -211,16 +212,16 @@ def _read(self, fp, fpname):
 				break
 			lineno = lineno + 1
 			# comment or blank line?
-			if line.strip() == '' or line[0] in '#;':
+			if line.strip() == '' or self.re_comment.match(line):
 				continue
 			if line.split(None, 1)[0].lower() == 'rem' and line[0] in "rR":
 				# no leading whitespace
 				continue
 			else:
 				# is it a section header?
-				mo = self.SECTCRE.match(line)
+				mo = self.SECTCRE.match(line.strip())
 				if mo:
-					sectname = mo.group('header')
+					sectname = mo.group('header').strip()
 					if sectname in self._sections:
 						cursect = self._sections[sectname]
 					elif sectname == cp.DEFAULTSECT:
@@ -332,6 +333,10 @@ def write(self):
 			close_fp = True
 		else:
 			fp.seek(0)
+			# make sure we do not overwrite into an existing file
+			if hasattr(fp, 'truncate'):
+				fp.truncate()
+			#END 
 		# END handle stream or file
 
 		# WRITE DATA

Diff for: git/test/fixtures/git_config

@@ -1,22 +1,28 @@
 [core]
 	repositoryformatversion = 0
 	filemode = true
-	bare = false
-	logallrefupdates = true
+    bare = false
+    logallrefupdates = true
 [remote "origin"]
 	fetch = +refs/heads/*:refs/remotes/origin/*
 	url = git://gitorious.org/~byron/git-python/byrons-clone.git
 	pushurl = [email protected]:~byron/git-python/byrons-clone.git
-[branch "master"]
+# a tab indented section header
+	[branch "master"]
 	remote = origin
 	merge = refs/heads/master
-[remote "mainline"]
+# an space indented section header
+  [remote "mainline"]
+    # space indented comment
 	url = git://gitorious.org/git-python/mainline.git
 	fetch = +refs/heads/*:refs/remotes/mainline/*
+
 [remote "MartinMarcher"]
+	# tab indented comment
 	url = git://gitorious.org/~martin.marcher/git-python/serverhorror.git
 	fetch = +refs/heads/*:refs/remotes/MartinMarcher/*
-[gui]
+    # can handle comments - the section name is supposed to be stripped
+[  gui ]
 	geometry = 1316x820+219+243 207 192
 [branch "mainline_performance"]
 	remote = mainline

Diff for: git/test/test_config.py

@@ -30,7 +30,9 @@ def test_read_write(self):
             w_config.read()                 # enforce reading
             assert w_config._sections
             w_config.write()                # enforce writing
-            assert file_obj.getvalue() == file_obj_orig.getvalue()
+            
+            # we stripped lines when reading, so the results differ
+            assert file_obj.getvalue() != file_obj_orig.getvalue()
 
             # creating an additional config writer must fail due to exclusive access
             self.failUnlessRaises(IOError, GitConfigParser, file_obj, read_only = False)
@@ -56,10 +58,10 @@ def test_read_write(self):
 
             file_obj.seek(0)
             r_config = GitConfigParser(file_obj, read_only=True)
+            #print file_obj.getvalue()
             assert r_config.has_section(sname)
             assert r_config.has_option(sname, oname)
             assert r_config.get(sname, oname) == val
-            
         # END for each filename
 
     def test_base(self):