Skip to content

Commit 4810491

Browse files
author
jcole-crowdstrike
committed
Fixing Windows encoding issue.
Stdout is being encoded as Windows-1251 instead of UTF-8 due to passing universal_newlines as True to subprocess.
1 parent 827e986 commit 4810491

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: git/remote.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,7 @@ def _get_fetch_info_from_stderr(
891891
None,
892892
progress_handler,
893893
finalizer=None,
894-
decode_streams=False,
894+
decode_streams=True,
895895
kill_after_timeout=kill_after_timeout,
896896
)
897897

@@ -1068,7 +1068,7 @@ def fetch(
10681068
Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_fetch_options)
10691069

10701070
proc = self.repo.git.fetch(
1071-
"--", self, *args, as_process=True, with_stdout=False, universal_newlines=True, v=verbose, **kwargs
1071+
"--", self, *args, as_process=True, with_stdout=False, v=verbose, **kwargs
10721072
)
10731073
res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
10741074
if hasattr(self.repo.odb, "update_cache"):

0 commit comments

Comments
 (0)