Skip to content

Commit 35bceb1

Browse files
committed
Merge pull request #16 from mike-perdide/master
improved comparison between Object instances to check for compatibility of the other side first. Previously, and exception would be thrown. This adds convenience in an area which probably is not performance critical.
2 parents e7fa5ef + 0968971 commit 35bceb1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Diff for: git/objects/base.py

+4
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,14 @@ def _set_cache_(self, attr):
7777

7878
def __eq__(self, other):
7979
""":return: True if the objects have the same SHA1"""
80+
if not hasattr(other, 'binsha'):
81+
return False
8082
return self.binsha == other.binsha
8183

8284
def __ne__(self, other):
8385
""":return: True if the objects do not have the same SHA1 """
86+
if not hasattr(other, 'binsha'):
87+
return True
8488
return self.binsha != other.binsha
8589

8690
def __hash__(self):

0 commit comments

Comments
 (0)