Skip to content

Commit 1207747

Browse files
mmulichByron
authored andcommitted
Use the Git class type definition within Repo classmethods
Allow the GitCommandWrapperType definition to be used within the Repo classmethods. This change follows the intended purpose as stated in the code, "Subclasses may easily bring in their own custom types by placing a constructor or type here." The usecase that prompted this change has to do with `GIT_SSH_COMMAND`. The goal is to setup a custom `Git` class with knowledge of the value, something like as follows ```python from git import Git as BaseGit, Repo as BaseRepo class Git(BaseGit): def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) # For example, assign the SSH command using the current flask # app's configured setting. self.update_environment(GIT_SSH_COMMAND=current_app.config['GIT_SSH_COMMAND']) class Repo(BaseRepo): GitCommandWrapperType = _Git ``` With this change, the above example will allow the developer to use `Repo.clone_from(...)` with the indended outcome. Otherwise the developer will have two differing result when using `Repo(...)` vs `Repo.clone_from(...)`.
1 parent bd0fa88 commit 1207747

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: git/repo/base.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,7 @@ def init(cls, path: Union[PathLike, None] = None, mkdir: bool = True, odbt: Type
10421042
os.makedirs(path, 0o755)
10431043

10441044
# git command automatically chdir into the directory
1045-
git = Git(path)
1045+
git = cls.GitCommandWrapperType(path)
10461046
git.init(**kwargs)
10471047
return cls(path, odbt=odbt)
10481048

@@ -1142,7 +1142,7 @@ def clone_from(cls, url: PathLike, to_path: PathLike, progress: Optional[Callabl
11421142
:param multi_options: See ``clone`` method
11431143
:param kwargs: see the ``clone`` method
11441144
:return: Repo instance pointing to the cloned directory"""
1145-
git = Git(os.getcwd())
1145+
git = cls.GitCommandWrapperType(os.getcwd())
11461146
if env is not None:
11471147
git.update_environment(**env)
11481148
return cls._clone(git, url, to_path, GitCmdObjectDB, progress, multi_options, **kwargs)

0 commit comments

Comments
 (0)