Skip to content

Fix broken workspace integration test TestMissingBackup(PVC) #9990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
jenting opened this issue May 13, 2022 · 2 comments · Fixed by #10147
Closed
Tracked by #7901

Fix broken workspace integration test TestMissingBackup(PVC) #9990

jenting opened this issue May 13, 2022 · 2 comments · Fixed by #10147
Assignees
Labels
type: bug Something isn't working

Comments

@jenting
Copy link
Contributor

jenting commented May 13, 2022

Bug description

Fix the broken workspace integration test TestMissingBackup of PVC test

{Name: "pvc", FF: []wsapi.WorkspaceFeatureFlag{wsapi.WorkspaceFeatureFlag_PERSISTENT_VOLUME_CLAIM}},

=== RUN   TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks/pvc_backup_init
    content_test.go:205: cannot start workspace: "rpc error: code = Internal desc = runtime error: invalid memory address or nil pointer dereference"

Steps to reproduce

Run the integration test

./dev/preview/install-k3s-kubeconfig.sh
cd test
go test -v ./... \
  -kubeconfig=/home/gitpod/.kube/config \
  -namespace=default \
  -run=TestMissingBackup

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@jenting jenting added the type: bug Something isn't working label May 13, 2022
@jenting
Copy link
Contributor Author

jenting commented May 13, 2022

cc @sagor999

@sagor999 sagor999 self-assigned this May 13, 2022
@sagor999 sagor999 moved this to In Progress in 🌌 Workspace Team May 13, 2022
@sagor999
Copy link
Contributor

@jenting this is an interesting one.
In this PR it longer crashes: #9475
But, it still fails with context deadline.
PVC is stuck in pending:
no persistent volumes available for this claim and no storage class is set
But looking at storage classes:

kubectl get storageclass
NAME                   PROVISIONER             RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
local-path (default)   rancher.io/local-path   Delete          WaitForFirstConsumer   false                  24h

It seems like local-path one is supposed to be a default one (meaning if PVC doesn't specify storage class, it should use that one). Though it doesn't seem to be the case.

🤔

To fix this test in dev env, I think it will be best to do it as part of this task then: #10017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants