-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[PVC][chore] remove contentDescriptorToLayer in favor of contentDescriptorToLayerPVC #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This doesn't quite work for old way of doing things, since ws-daemon attempts to place
It is not clear how easy it would be to change that function, and I don't think it will be worth the effort (and potential unaccounted edge cases) So I think it is best to just remove old contentDescriptorToLayer once we 100% switch to PVC.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Changed title of the issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
After this PR gets merged, we should harmonize
contentDescriptorToLayerPVC
andcontentDescriptorToLayer
by switching to using/.workspace' folder to place content.json file, instead of placing it into
/workspace` folder, and thus removing a separate code path for PVC implementation.For more info: #9242 (comment)
The text was updated successfully, but these errors were encountered: