Skip to content

Prebuild Loading Screen doesn't auto progress when done #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
svenefftinge opened this issue Dec 20, 2021 · 6 comments
Closed
Tracked by #7901

Prebuild Loading Screen doesn't auto progress when done #7311

svenefftinge opened this issue Dec 20, 2021 · 6 comments
Labels
aspect: performance anything related to performance meta: stale This issue/PR is stale and will be closed soon team: workspace Issue belongs to the Workspace team type: bug Something isn't working

Comments

@svenefftinge
Copy link
Member

Bug description

When starting a workspace on which a rebuild is running, the screen blocks and shows the log output of the rebuild.
When done it should automatically progress to starting a new workspace.
It doesn't (always?) do that when the time spent on that page was long.

Steps to reproduce

start a workspace on a commit that is being prebuild and the prebuild takes a few minutes

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@jmls
Copy link

jmls commented Dec 21, 2021

yup, I get this all the time

@sagor999 sagor999 added the team: workspace Issue belongs to the Workspace team label Feb 25, 2022
@kylos101 kylos101 added the aspect: performance anything related to performance label Mar 18, 2022
@kylos101
Copy link
Contributor

kylos101 commented Mar 18, 2022

I just experienced a long wait with https://gitpodio-gitpod-sdmofwboptx.ws-us38xl.gitpod.io/, with instance ID 22775e2b-8c57-4be5-9908-363e7838350d.

Web app logs
2022-03-18 19:52:24.799 GMT Phase 1 - Pending
2022-03-18 19:52:24.824 GMT Phase 2 - Creating
2022-03-18 19:52:29.008 GMT Phase 3 - Initializing
2022-03-18 19:56:40.450 GMT Phase 4 - Running
2022-03-18 19:57:13.206 GMT Phase 5 - Stopping
2022-03-18 19:59:11.344 GMT Phase 6 - Stopped

4m 11s to initialize (according to web app logs).

Workspace logs
2022-03-18 19:52:24.000 GMT StartWorkspace
2022-03-18 19:52:35.000 GMT Wait until content available
2022-03-18 19:56:40.000 GMT supervisor: workspace content available
At this point the IDE takes over and the workspace is usable.
2022-03-18 19:57:13.000 GMT StopWorkspace

4m 5s to restore content (according to workspace logs). 😬

Next steps:

  • Benchmark times (1) to transfer the tar file from GCS (2) to extract the TAR on the node to the pod's /workspace
  • Add logging and traces for both events (so we can more easily capture for the future)

@kylos101 kylos101 moved this to Scheduled in 🌌 Workspace Team Mar 18, 2022
@kylos101
Copy link
Contributor

The PVC work that we're exploring should help with this, removing from scheduled work for now.

CC: @sagor999

@kylos101 kylos101 removed the status in 🌌 Workspace Team Mar 31, 2022
@kylos101
Copy link
Contributor

(Added to our durability epic so we don't lose track/sight)

@sagor999
Copy link
Contributor

I don't think PVC work would help here. This seems like webapp related issue potentially?
Though we did fix a bunch of issues related to prebuilds recently, and I am wondering if this is even still happens?
@jmls are you still experiencing this by any chance?

@atduarte atduarte added the type: bug Something isn't working label Jul 25, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@stale stale bot closed this as completed Nov 26, 2022
@stale stale bot moved this to Awaiting Deployment in 🌌 Workspace Team Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: performance anything related to performance meta: stale This issue/PR is stale and will be closed soon team: workspace Issue belongs to the Workspace team type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants