Skip to content

[PVC][integration test] restart control plane components when/after volume snapshot in-progess/done #13146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
jenting opened this issue Sep 20, 2022 · 4 comments · Fixed by #13518
Closed
Tracked by #7901
Assignees
Labels
team: workspace Issue belongs to the Workspace team

Comments

@jenting
Copy link
Contributor

jenting commented Sep 20, 2022

Is your feature request related to a problem? Please describe

Add/modify the integration test to test the control plane component (ws-manager, snapshot-controller) restart when volume snapshot in-progress or after volume snapshot is done.

Describe the behaviour you'd like

Describe alternatives you've considered

Additional context

#7901

@jenting jenting added the team: workspace Issue belongs to the Workspace team label Sep 20, 2022
@sagor999
Copy link
Contributor

I tested restarting both snapshot-controller and ws-manager after and during workspace shutdown and both worked flawlessly as far as I can tell.
Also tested ws-manager restart with 150 volume snapshots.

@jenting
Copy link
Contributor Author

jenting commented Sep 23, 2022

I tested restarting both snapshot-controller and ws-manager after and during workspace shutdown and both worked flawlessly as far as I can tell.

Also tested ws-manager restart with 150 volume snapshots.

Nice 🤩 Thank you @sagor999

@kylos101
Copy link
Contributor

@sagor999 thank you so much!

@jenting the issue description and title confuse me, because they mentions both loadgen and integration tests. I think they will be similar effort...therefore my preference would be to do with integration tests (so we test more often, instead of once a week). Also, this will keep loadgen flexible...if we need to restart ws-manager or snapshot-controller, we can do manually.

@jenting
Copy link
Contributor Author

jenting commented Sep 23, 2022

I don't have a strong reason to add a restart control plane component on both loadgen and integration tests.

But I was like to catch the incident we met that over 100+ VolumeSnapshot, restart control plane, and create new workspace will hang.
I think it can only be caught if we run loadgen test because the integration test generally would not have stress test on over 100+ VolumeSnapshots. But we could add the manual step that for each loadgen test finished, make sure to restart the control plane components to see if the new workspace can open or not. After that, we could change this issue to work on integration tests only.

@jenting jenting changed the title [PVC][loadgen][integration] test control plane component restart when/after volume snapshot in-progess/done [PVC][integration] test control plane component restart when/after volume snapshot in-progess/done Sep 28, 2022
@jenting jenting changed the title [PVC][integration] test control plane component restart when/after volume snapshot in-progess/done [PVC][integration test] restart control plane components when/after volume snapshot in-progess/done Sep 28, 2022
@jenting jenting self-assigned this Sep 30, 2022
@jenting jenting moved this to In Progress in 🌌 Workspace Team Sep 30, 2022
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Oct 3, 2022
@kylos101 kylos101 moved this from Awaiting Deployment to Done in 🌌 Workspace Team Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants