-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[PVC][integration test] restart control plane components when/after volume snapshot in-progess/done #13146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tested restarting both snapshot-controller and ws-manager after and during workspace shutdown and both worked flawlessly as far as I can tell. |
Nice 🤩 Thank you @sagor999 |
@sagor999 thank you so much! @jenting the issue description and title confuse me, because they mentions both loadgen and integration tests. I think they will be similar effort...therefore my preference would be to do with integration tests (so we test more often, instead of once a week). Also, this will keep loadgen flexible...if we need to restart ws-manager or snapshot-controller, we can do manually. |
I don't have a strong reason to add a restart control plane component on both loadgen and integration tests. But I was like to catch the incident we met that over 100+ VolumeSnapshot, restart control plane, and create new workspace will hang. |
Uh oh!
There was an error while loading. Please reload this page.
Is your feature request related to a problem? Please describe
Add/modify the integration test to test the control plane component (ws-manager, snapshot-controller) restart when volume snapshot in-progress or after volume snapshot is done.
Describe the behaviour you'd like
Describe alternatives you've considered
Additional context
#7901
The text was updated successfully, but these errors were encountered: