Skip to content

[PVC] Open workspace from prebuild PVC, no message This task ran as a workspace prebuild on CLI #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
jenting opened this issue Aug 29, 2022 · 5 comments · Fixed by #12746
Closed
Tracked by #7901
Assignees
Labels
team: workspace Issue belongs to the Workspace team type: bug Something isn't working

Comments

@jenting
Copy link
Contributor

jenting commented Aug 29, 2022

Bug description

[PVC] Open workspace from prebuild PVC, no message This task ran as a workspace prebuild on CLI

Steps to reproduce

  • Prebuild + PVC
  • The user account with PVC
  • The user open the workspace from prebuild

Workspace affected

No response

Expected behavior

We should see the message This task ran as a workspace prebuild in workspace CLI when we open from prebuild. After that, we could know whether the workspace open from prebuild or not.

Example repository

No response

Anything else?

#7901

@jenting jenting added the type: bug Something isn't working label Aug 29, 2022
@jenting jenting added the team: workspace Issue belongs to the Workspace team label Aug 29, 2022
@kylos101
Copy link
Contributor

kylos101 commented Aug 30, 2022

@jenting can you share more detail about what the expected behavior is? I assume you mean to say that the text we normally get from a prebuild is no longer being displayed upon regular workspace start?

cc: @sagor999 this seems like a change in behavior, wdyt?

@jenting
Copy link
Contributor Author

jenting commented Aug 30, 2022

We should be able to see the message This task ran as a workspace prebuild on the workspace CLI terminal.
Otherwise, the user can't know whether the workspace is started from prebuilds or git clone.

@sagor999
Copy link
Contributor

Ah, this is a valid concern. Needs to be looked into.
I will Schedule this then.

@sagor999 sagor999 moved this to Scheduled in 🌌 Workspace Team Aug 30, 2022
@jenting jenting self-assigned this Aug 30, 2022
@jenting jenting moved this from Scheduled to In Progress in 🌌 Workspace Team Aug 30, 2022
@kylos101
Copy link
Contributor

@jenting as getting PVC working with regular prebuilds is a higher priority, for now, I will move this back to scheduled. 🙏

@kylos101 kylos101 moved this from In Progress to Scheduled in 🌌 Workspace Team Aug 31, 2022
@sagor999 sagor999 assigned sagor999 and unassigned jenting Sep 6, 2022
@sagor999 sagor999 moved this from Scheduled to In Progress in 🌌 Workspace Team Sep 6, 2022
@jenting
Copy link
Contributor Author

jenting commented Sep 7, 2022

From my observation, after workspace ready, the content is

  • Without PVC: from-prebuild
  • With PVC: from-other

Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Sep 12, 2022
@sagor999 sagor999 moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Sep 21, 2022
@sagor999 sagor999 moved this from In Validation to Done in 🌌 Workspace Team Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants