Skip to content

Update GCP PD CSI driver from v1.4.0 to v1.7.1 to include faster PVC mount time fix #10210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
jenting opened this issue May 24, 2022 · 9 comments
Closed
Tracked by #7901
Assignees
Labels
team: workspace Issue belongs to the Workspace team

Comments

@jenting
Copy link
Contributor

jenting commented May 24, 2022

Is your feature request related to a problem? Please describe

Currently, in the workspace-preview, we shipped the GCP PD CSI driver with v1.4.0, we should bump the version v1.7.1 which includes Pavel's work on making the PVC mounting time more faster.
But we have to wait the upstream to release v1.7.0 container image first. kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1000

Describe the behaviour you'd like

Bump the GCP PD CSI driver to v1.7.0.

Describe alternatives you've considered

No

Additional context

#7901

@jenting jenting changed the title Bump GCP PD CSI driver from v1.4.0 to v1.7.0 Bump GCP PD CSI driver from v1.4.0 to v1.7.1 May 25, 2022
@jenting jenting moved this to Blocked in 🌌 Workspace Team May 25, 2022
@jenting
Copy link
Contributor Author

jenting commented May 25, 2022

Waits upstream release new container image.

@jenting jenting self-assigned this May 25, 2022
@sagor999
Copy link
Contributor

@jenting as part of this task, can you also make sure we are using this params now as well:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#956
This is to ensure that we poll for gcp attachment event faster then default 5sec, that way we can proceed with workspace container creation faster, instead of waiting 10+ seconds. More info: #9054

@kylos101
Copy link
Contributor

@jenting is this still blocked, or did you mean for status to be something else?

@jenting
Copy link
Contributor Author

jenting commented May 30, 2022

I'm waiting for the upstream to release the next container image, so I put into blocked status.

@jenting jenting added the team: workspace Issue belongs to the Workspace team label May 30, 2022
@sagor999 sagor999 changed the title Bump GCP PD CSI driver from v1.4.0 to v1.7.1 Update GCP PD CSI driver from v1.4.0 to v1.7.1 to include faster PVC mount time fix Jun 1, 2022
@sagor999
Copy link
Contributor

sagor999 commented Jun 8, 2022

@kylos101 before we will start dog fooding PVC work at gitpod, we need to make sure that this issue is closed.
Why? Without it, PVC attach time is considerably longer and first impressions matter. If new PVC approach will be perceived as much slower then old one, we will have unnecessary friction with adopting this feature.

@kylos101
Copy link
Contributor

kylos101 commented Jun 8, 2022

@sagor999 👍 yes, @jenting indicated that today too, and shared work is in-progress here.

One option may be for us to build this image ourselves, if it cannot be available fast enough through this means. wdyt? 🤔

@sagor999
Copy link
Contributor

sagor999 commented Jun 8, 2022

Yup, that is a good option (to build image)

@sagor999
Copy link
Contributor

sagor999 commented Jun 8, 2022

Seems like 1.7.1 was just released:
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/releases/tag/v1.7.1

@jenting jenting moved this from Blocked to In Progress in 🌌 Workspace Team Jun 9, 2022
@jenting jenting closed this as completed Jun 10, 2022
Repository owner moved this from In Progress to Done in 🌌 Workspace Team Jun 10, 2022
@jenting jenting reopened this Jun 10, 2022
@jenting jenting moved this from Done to In Progress in 🌌 Workspace Team Jun 10, 2022
@aledbf aledbf closed this as completed Jun 10, 2022
Repository owner moved this from In Progress to Done in 🌌 Workspace Team Jun 10, 2022
@kylos101
Copy link
Contributor

Thank you, @aledbf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants