Skip to content

Find a way to display workspace ID in GCP Snapshots page #10186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
jenting opened this issue May 23, 2022 · 9 comments
Closed
Tracked by #7901

Find a way to display workspace ID in GCP Snapshots page #10186

jenting opened this issue May 23, 2022 · 9 comments
Assignees
Labels
team: workspace Issue belongs to the Workspace team

Comments

@jenting
Copy link
Contributor

jenting commented May 23, 2022

Is your feature request related to a problem? Please describe

We want the GCP Snapshots page contains the information of workspace ID. So, it's convenient to see the snapshot belongs to which workspace ID.

Currently, the snapshot contains the PVC name only.
image

And the PVC contains the information as.

  • PV name
  • PVC name (same as workspace name)
    image

Although we could get the PVC name from snapshot first, and then get the workspace ID from description.
It'd be good if we could found the workspace ID directly from the snapshot.

Describe the behaviour you'd like

Display the workspace ID in snapshot either by description or label.

Describe alternatives you've considered

Manually check snapshot to get the PVC name, and then check the disks to find the workspace ID from the description.

Additional context

#7901

@jenting
Copy link
Contributor Author

jenting commented May 23, 2022

@atduarte atduarte added the team: workspace Issue belongs to the Workspace team label May 23, 2022
@jenting
Copy link
Contributor Author

jenting commented May 24, 2022

We should be able to achieve by adding the flag --extra-create-metadata to the csi-snapshotter and updates the gcp-compute-persistent-disk-csi-driver from v1.4.0 to v1.7.0 that includes the PR and Pavel's PR. After that, the snapshot contains the VolumeSnapshot name/namespace and VolumeSnapshotContent name in snapshot description field.

However, the release v1.7.0 doesn't have the corresponding container image be released. We have to wait the upstream to release the v1.7.0 container image.

@jenting jenting changed the title Research a way to sync volumesnapshot labels to snapshot in GCP Research a way to show workspace ID in GCP Snapshots page May 24, 2022
@jenting jenting changed the title Research a way to show workspace ID in GCP Snapshots page Find a way to display workspace ID in GCP Snapshots page May 24, 2022
@jenting jenting moved this from In Progress to Blocked in 🌌 Workspace Team May 24, 2022
@sagor999
Copy link
Contributor

Keep in mind that PVCs are ephemeral. They exist only as long as workspace is running. When workspace stops, PVC gets deleted and only Volume Snapshot will remain.

@kylos101
Copy link
Contributor

@jenting is this still blocked, or did you mean for status to be something else?

@jenting
Copy link
Contributor Author

jenting commented May 30, 2022

I'm waiting for the upstream to release the next container image, so I put into blocked status.

@jenting jenting moved this from Blocked to In Progress in 🌌 Workspace Team Jun 10, 2022
@sagor999
Copy link
Contributor

@jenting can you also explore if it is possible to add labels to snapshots? Not just description.
Why labels? Labels allow us to filter the cost.
We might need to introduce upstream PR for this.

@jenting
Copy link
Contributor Author

jenting commented Jun 10, 2022

If I remember correctly, there is no way currently.

But we could improve code to upstream 😄

@jenting jenting closed this as completed Jun 10, 2022
Repository owner moved this from In Progress to Done in 🌌 Workspace Team Jun 10, 2022
@jenting
Copy link
Contributor Author

jenting commented Jun 10, 2022

@jenting can you also explore if it is possible to add labels to snapshots? Not just description. Why labels? Labels allow us to filter the cost. We might need to introduce upstream PR for this.

Which label are we preferred to add to filter the cost? I could think is the label to diffentiate the standard/XL cluster.

@sagor999
Copy link
Contributor

Similar to what we do for VMs:
https://github.com/gitpod-io/ops/blob/3da5107b309bcc6ffe644ce7f5329431f0daf46a/deploy/workspace/cluster-up.sh#L150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants