ws-manager: return error if restore volume snapshot to smaller PVC size

Signed-off-by: JenTing Hsiao <[email protected]>

Author: jenting

components/ws-manager/pkg/manager/create.go

@@ -245,7 +245,7 @@ func mergeProbe(dst, src reflect.Value) (err error) {
 	return nil
 }
 
-func (m *Manager) createPVCForWorkspacePod(startContext *startWorkspaceContext) (*corev1.PersistentVolumeClaim, error) {
+func (m *Manager) createPVCForWorkspacePod(ctx context.Context, startContext *startWorkspaceContext) (*corev1.PersistentVolumeClaim, error) {
 	req := startContext.Request
 	var prefix string
 	switch req.Type {

components/ws-manager/pkg/manager/create_test.go

@@ -289,7 +289,7 @@ func TestCreatePVCForWorkspacePod(t *testing.T) {
 				fixture.Context = ctx
 			}
 
-			pvc, serr := manager.createPVCForWorkspacePod(fixture.Context)
+			pvc, serr := manager.createPVCForWorkspacePod(context.Background(), fixture.Context)
 			result := gold{}
 			if serr != nil {
 				result.Error = serr.Error()

components/ws-manager/pkg/manager/manager.go

@@ -263,8 +263,8 @@ func (m *Manager) StartWorkspace(ctx context.Context, req *api.StartWorkspaceReq
 	_, createPVC = pod.Labels[pvcWorkspaceFeatureLabel]
 
 	if createPVC {
+		var volumeSnapshot volumesnapshotv1.VolumeSnapshot
 		if startContext.VolumeSnapshot != nil && startContext.VolumeSnapshot.VolumeSnapshotName != "" {
-			var volumeSnapshot volumesnapshotv1.VolumeSnapshot
 			err = m.Clientset.Get(ctx, types.NamespacedName{Namespace: m.Config.Namespace, Name: startContext.VolumeSnapshot.VolumeSnapshotName}, &volumeSnapshot)
 			if k8serr.IsNotFound(err) {
 				// restore volume snapshot from handle
@@ -273,12 +273,31 @@ func (m *Manager) StartWorkspace(ctx context.Context, req *api.StartWorkspaceReq
 					clog.WithError(err).Error("was unable to restore volume snapshot")
 					return nil, err
 				}
+
+				// update the volumeSnapshot variable
+				if err := m.Clientset.Get(ctx, types.NamespacedName{Namespace: m.Config.Namespace, Name: startContext.VolumeSnapshot.VolumeSnapshotName}, &volumeSnapshot); err != nil {
+					return nil, err
+				}
 			} else if err != nil {
 				clog.WithError(err).Error("was unable to get volume snapshot")
 				return nil, err
 			}
+
+			// check the PVC size is not less than the volume snapshot size
+			PVCConfig := m.Config.WorkspaceClasses[config.DefaultWorkspaceClass].PVC
+			if startContext.Class != nil {
+				PVCConfig = startContext.Class.PVC
+			}
+
+			if volumeSnapshot.Status != nil &&
+				volumeSnapshot.Status.RestoreSize != nil &&
+				PVCConfig.Size.Cmp(*volumeSnapshot.Status.RestoreSize) == -1 {
+				return nil, xerrors.Errorf("cannot restore volume snapshot from size %s to pvc size %s", volumeSnapshot.Status.RestoreSize.String(), PVCConfig.Size.String())
+			}
 		}
-		pvc, err = m.createPVCForWorkspacePod(startContext)
+
+		// create PVC object
+		pvc, err = m.createPVCForWorkspacePod(ctx, startContext)
 		if err != nil {
 			return nil, xerrors.Errorf("cannot create pvc for workspace pod: %w", err)
 		}