[ws-manager-mk2] Remove headless field (#16611)

Author: WVerlaek

components/ws-manager-api/go/crd/v1/workspace_types.go

@@ -116,7 +116,6 @@ type PortSpec struct {
 // WorkspaceStatus defines the observed state of Workspace
 type WorkspaceStatus struct {
 	PodStarts  int    `json:"podStarts"`
-	Headless   bool   `json:"headless"`
 	URL        string `json:"url,omitempty"`
 	OwnerToken string `json:"ownerToken,omitempty"`
 

components/ws-manager-mk2/config/crd/bases/workspace.gitpod.io_workspaces.yaml

@@ -501,8 +501,6 @@ spec:
                       type: string
                     type: array
                 type: object
-              headless:
-                type: boolean
               ownerToken:
                 type: string
               phase:
@@ -538,7 +536,6 @@ spec:
               url:
                 type: string
             required:
-            - headless
             - podStarts
             type: object
         type: object

components/ws-manager-mk2/controllers/workspace_controller.go

@@ -219,7 +219,7 @@ func (r *WorkspaceReconciler) actOnStatus(ctx context.Context, workspace *worksp
 	case isWorkspaceBeingDeleted(workspace) && !isPodBeingDeleted(pod):
 		return r.deleteWorkspacePod(ctx, pod, "workspace deleted")
 
-	case workspace.Status.Headless && workspace.Status.Phase == workspacev1.WorkspacePhaseStopped && !isPodBeingDeleted(pod):
+	case workspace.IsHeadless() && workspace.Status.Phase == workspacev1.WorkspacePhaseStopped && !isPodBeingDeleted(pod):
 		// Workspace was requested to be deleted, propagate by deleting the Pod.
 		// The Pod deletion will then trigger workspace disposal steps.
 		err := r.Client.Delete(ctx, pod)