[stripe] Return NotFound for non-existent attribution IDs (#16600)

Author: easyCZ

components/server/ee/src/user/stripe-service.ts

@@ -14,6 +14,8 @@ import {
     stripeClientRequestsCompletedDurationSeconds,
 } from "../../../src/prometheus-metrics";
 import { BillingServiceClient, BillingServiceDefinition } from "@gitpod/usage-api/lib/usage/v1/billing.pb";
+import { ResponseError } from "vscode-ws-jsonrpc";
+import { ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error";
 
 @injectable()
 export class StripeService {
@@ -57,7 +59,10 @@ export class StripeService {
     async getPortalUrlForAttributionId(attributionId: string, returnUrl: string): Promise<string> {
         const customerId = await this.findCustomerByAttributionId(attributionId);
         if (!customerId) {
-            throw new Error(`No Stripe Customer ID found for '${attributionId}'`);
+            throw new ResponseError(
+                ErrorCodes.NOT_FOUND,
+                `No Stripe Customer ID for attribution ID '${attributionId}'`,
+            );
         }
         const session = await reportStripeOutcome("portal_create_session", () => {
             return this.getStripe().billingPortal.sessions.create({