Skip to content

Commit 0a130f1

Browse files
jentingroboquat
authored andcommitted
Skip the cannot mount workspace event because it might be an intermediate state
Signed-off-by: JenTing Hsiao <[email protected]>
1 parent 5fffa02 commit 0a130f1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

components/ws-manager/pkg/manager/status.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,8 +620,8 @@ func extractFailure(wso workspaceObjects, metrics *metrics) (string, *api.Worksp
620620
// ref: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/issues/608
621621
return "", nil
622622
} else if strings.Contains(evt.Message, workspaceVolumeName) {
623-
// ideally we do not just use evt.Message as failure reason because it contains internal paths and is not useful for the user
624-
return "cannot mount workspace", nil
623+
// ref: https://github.com/gitpod-io/gitpod/issues/14032
624+
return "", nil
625625
} else {
626626
// if this happens we did not do a good job because that means we've introduced another volume to the pod
627627
// but did not consider that mounting it might fail.

0 commit comments

Comments
 (0)